Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): ecs hotswap deployment waits correctly for success or failure #28448

Merged
merged 14 commits into from
Mar 26, 2024
Merged

fix(cli): ecs hotswap deployment waits correctly for success or failure #28448

merged 14 commits into from
Mar 26, 2024

Commits on Feb 13, 2024

  1. test: add hotswap ecs integration test

    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    83c37c1 View commit details
    Browse the repository at this point in the history

  2. test: add integ test for waiting on ecs hotswap

    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    313afb9 View commit details
    Browse the repository at this point in the history

  3. fix: improve deployment completion checking 

    new deployments are initially in an intermediate state with 0 counts which the waiter may match and return on immediately

this uses a more reliable property that signals deployment completion
    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    f0280e1 View commit details
    Browse the repository at this point in the history

  4. fix: reverse logic to support multiple services

    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d4c772d View commit details
    Browse the repository at this point in the history

  5. fix: failure and non-rolling update waiter conditions

    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1bef62e View commit details
    Browse the repository at this point in the history

  6. refactor: rename custom waiter for clearer error message

    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    7e3b63b View commit details
    Browse the repository at this point in the history

  7. test: integ test for failed ecs hotswap

    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    18fbe29 View commit details
    Browse the repository at this point in the history

  8. test: improve speed of ecs integration tests

    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1618d84 View commit details
    Browse the repository at this point in the history

  9. fix: faster polling for ecs hotswap 

    the FAILED intermediate state is short

faster polling ensures responsive deployments
    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    807d834 View commit details
    Browse the repository at this point in the history

  10. fix: simplify waiter conditions

    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    8a9a126 View commit details
    Browse the repository at this point in the history

  11. test: remove high task count as no longer necessary to optimise circu… 

    …it breaker

see https://aws.amazon.com/about-aws/whats-new/2024/01/amazon-ecs-deployment-monitoring-responsiveness-services/
    @tomwwright
    tomwwright committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    e01ba9d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge branch 'main' into fix-ecs-service-hotswap-wait

    @paulhcsun
    paulhcsun committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    162139e View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge branch 'main' into fix-ecs-service-hotswap-wait

    @colifran
    colifran committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b16e436 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-ecs-service-hotswap-wait

    @mergify
    mergify[bot] committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    85517d3 View commit details
    Browse the repository at this point in the history