Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): ecs hotswap deployment waits correctly for success or failure #28448

Merged
merged 14 commits into from
Mar 26, 2024

Conversation

tomwwright
Copy link
Contributor

@tomwwright tomwwright commented Dec 21, 2023

Reraising #27943 as it was incorrectly closed as stale. See original PR for details.

Closes #27882. See linked issue for further details.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Dec 21, 2023
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 21, 2023 06:28
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 and removed p2 labels Dec 21, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 21, 2023
@kaizencc kaizencc added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Dec 23, 2023
@kaizencc
Copy link
Contributor

Sorry for the tough battle with the automation on the previous PR @tomwwright. I'll make sure this gets looked at (although not right this instance). I've added the exemption label so hopefully our automation plays nice with you from now on.

I took a look at why the automation tried to close your PR and it looks like our automation shouldn't request changes with the cli code has changed warning. I'll see if I can update that to make it a more reasonable experience for you.

@kaizencc
Copy link
Contributor

exemption request (testing if this will make the automation happy; it should)

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Dec 23, 2023
@kaizencc
Copy link
Contributor

Ok I figured out the issue and fixed it in #28481, this PR will not get closed. But hopefully I'll get to it before 3 weeks anyway :)

@tomwwright
Copy link
Contributor Author

I've had a look at the error from the CodeBuild job, I think it's unrelated to my branch -- is this failure occurring on other PRs?

awslint: In package package.json
awslint: - [license/license-file] LICENSE should contain exactly '                                 Apache License
awslint:                            Version 2.0, January 2004
...
awslint:    limitations under the License.
awslint: ' (fixable)
awslint: - [license/notice-file] NOTICE does NOT begin with AWS Cloud Development Kit (AWS CDK),Copyright 2018-2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.,'
awslint: Error: Some package.json files had errors
awslint:     at main (/codebuild/output/src1006157556/src/github.com/aws/aws-cdk/tools/@aws-cdk/pkglint/bin/pkglint.js:30:15)
awslint:     at Object.<anonymous> (/codebuild/output/src1006157556/src/github.com/aws/aws-cdk/tools/@aws-cdk/pkglint/bin/pkglint.js:33:1)
awslint:     at Module._compile (node:internal/modules/cjs/loader:1256:14)
awslint:     at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
awslint:     at Module.load (node:internal/modules/cjs/loader:1119:32)
awslint:     at Module._load (node:internal/modules/cjs/loader:960:12)
awslint:     at Module.require (node:internal/modules/cjs/loader:1143:19)
awslint:     at require (node:internal/modules/cjs/helpers:121:18)
awslint:     at Object.<anonymous> (/codebuild/output/src1006157556/src/github.com/aws/aws-cdk/tools/@aws-cdk/pkglint/bin/pkglint:2:1)
awslint:     at Module._compile (node:internal/modules/cjs/loader:1256:14)
awslint: �[2K�[1G�[31merror�[39m Command failed with exit code 1.

@sakurai-ryo
Copy link
Contributor

Hi @tomwwright
This error has probably been fixed, so please try to pull from main.
#28542

@tomwwright
Copy link
Contributor Author

Hey @kaizencc, did we pass on the test pipeline? 😁 Let me know if there is anything for me to fix!

@tomwwright
Copy link
Contributor Author

Hey @kaizencc, still curious on the status of this one, when you have time to provide an update

@colifran
Copy link
Contributor

@tomwwright Just touching base to let you know I'm taking a look at this one for you.

@TheRealAmazonKendra
Copy link
Contributor

In unfortunate timing, we are fixing another pipeline issue.

@tomwwright
Copy link
Contributor Author

Thanks @colifran @TheRealAmazonKendra, how did the pipeline run go?

@colifran
Copy link
Contributor

@tomwwright we were having some other pipeline issues that should be resolved now. Just resubmitted this one to the test pipeline. Assuming everything passes, we can get this one merged in!

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@colifran colifran added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Mar 26, 2024
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this and thanks for your patience!

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 26, 2024 20:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed pr/needs-maintainer-review This PR needs a review from a Core Team Member pr/needs-cli-test-run This PR needs CLI tests run against it. labels Mar 26, 2024
Copy link
Contributor

mergify bot commented Mar 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 85517d3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5c30255 into aws:main Mar 26, 2024
8 of 9 checks passed
Copy link
Contributor

mergify bot commented Mar 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: ecs service hotswap deployment does not wait for deployment to complete
7 participants