Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route53: support for multivalue answer routing #28939

Closed
1 of 2 tasks
badmintoncryer opened this issue Jan 31, 2024 · 2 comments · Fixed by #28938
Closed
1 of 2 tasks

route53: support for multivalue answer routing #28939

badmintoncryer opened this issue Jan 31, 2024 · 2 comments · Fixed by #28938
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

Route53 can configure multivalue answer routing.
I want to specify multiValueAnswer parameter from RecordSet class.

Use Case

When configuring multi-value answer routing, it is always necessary to set it via the L1.

Proposed Solution

Add multiValueAnswer property to RecordSetProps.

    new route53.RecordSet(this, 'MultiValueAnswerRouting', {
      zone: hostedZone,
      recordName: 'www',
      target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
      multiValueAnswer: true, // add
    });

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.123.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 31, 2024
@github-actions github-actions bot added the @aws-cdk/aws-route53 Related to Amazon Route 53 label Jan 31, 2024
@badmintoncryer badmintoncryer mentioned this issue Jan 31, 2024
Merged
1 task
@pahud
Copy link
Contributor

pahud commented Jan 31, 2024

Yes I guess we could just expose this property to the surface
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-route53-recordset.html#cfn-route53-recordset-multivalueanswer

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 31, 2024
@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
@mergify mergify bot closed this as completed in #28938 Feb 7, 2024
mergify bot pushed a commit that referenced this issue Feb 7, 2024
@badmintoncryer
feat(route53): multivalue answer routing (#28938)
0e6e37e 
### Issue

Closes #28939.

### Reason for this change

When configuring multi-value answer routing, it was always necessary to set it via the L1 method or use an escape hatch.

### Description of changes

I added `multiValueAnswering` property to `RecordSetProps`.

```ts
    new route53.ARecord(this, 'MultiValueAnswerRouting', {
      zone: hostedZone,
      recordName: 'www',
      target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
      multiValueAnswer: true, // added
    });
```

### Description of how you validated changes

I added unit test and integ test.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TheRealAmazonKendra pushed a commit that referenced this issue Feb 9, 2024
@badmintoncryer @TheRealAmazonKendra
feat(route53): multivalue answer routing (#28938)
dec7de0 
### Issue

Closes #28939.

### Reason for this change

When configuring multi-value answer routing, it was always necessary to set it via the L1 method or use an escape hatch.

### Description of changes

I added `multiValueAnswering` property to `RecordSetProps`.

```ts
    new route53.ARecord(this, 'MultiValueAnswerRouting', {
      zone: hostedZone,
      recordName: 'www',
      target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
      multiValueAnswer: true, // added
    });
```

### Description of how you validated changes

I added unit test and integ test.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(route53): multivalue answer routing badmintoncryer/aws-cdk
2 participants
@pahud @badmintoncryer