fix(cli): ecs hotswap deployment waits correctly for success or failure

[tomwwright]

Reraising #27943 as it was incorrectly closed as stale. See original PR for details.

Closes #27882. See linked issue for further details.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[kaizencc]

Sorry for the tough battle with the automation on the previous PR @tomwwright. I'll make sure this gets looked at (although not right this instance). I've added the exemption label so hopefully our automation plays nice with you from now on.

I took a look at why the automation tried to close your PR and it looks like our automation shouldn't request changes with the cli code has changed warning. I'll see if I can update that to make it a more reasonable experience for you.

[kaizencc]

exemption request (testing if this will make the automation happy; it should)

[kaizencc]

Ok I figured out the issue and fixed it in #28481, this PR will not get closed. But hopefully I'll get to it before 3 weeks anyway :)

[tomwwright]

I've had a look at the error from the CodeBuild job, I think it's unrelated to my branch -- is this failure occurring on other PRs?

awslint: In package package.json
awslint: - [license/license-file] LICENSE should contain exactly '                                 Apache License
awslint:                            Version 2.0, January 2004
...
awslint:    limitations under the License.
awslint: ' (fixable)
awslint: - [license/notice-file] NOTICE does NOT begin with AWS Cloud Development Kit (AWS CDK),Copyright 2018-2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.,'
awslint: Error: Some package.json files had errors
awslint:     at main (/codebuild/output/src1006157556/src/github.com/aws/aws-cdk/tools/@aws-cdk/pkglint/bin/pkglint.js:30:15)
awslint:     at Object.<anonymous> (/codebuild/output/src1006157556/src/github.com/aws/aws-cdk/tools/@aws-cdk/pkglint/bin/pkglint.js:33:1)
awslint:     at Module._compile (node:internal/modules/cjs/loader:1256:14)
awslint:     at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
awslint:     at Module.load (node:internal/modules/cjs/loader:1119:32)
awslint:     at Module._load (node:internal/modules/cjs/loader:960:12)
awslint:     at Module.require (node:internal/modules/cjs/loader:1143:19)
awslint:     at require (node:internal/modules/cjs/helpers:121:18)
awslint:     at Object.<anonymous> (/codebuild/output/src1006157556/src/github.com/aws/aws-cdk/tools/@aws-cdk/pkglint/bin/pkglint:2:1)
awslint:     at Module._compile (node:internal/modules/cjs/loader:1256:14)
awslint: �[2K�[1G�[31merror�[39m Command failed with exit code 1.

[sakurai-ryo]

Hi @tomwwright
This error has probably been fixed, so please try to pull from main.
#28542

[tomwwright]

Hey @kaizencc, any progress on that testing pipeline? Anything I can help with?

[kaizencc]

Running it through the test pipeline now. Sorry :( and thanks for your patience.

[tomwwright]

Hey @kaizencc, did we pass on the test pipeline? 😁 Let me know if there is anything for me to fix!

[tomwwright]

Hey @kaizencc, still curious on the status of this one, when you have time to provide an update

[colifran]

@tomwwright Just touching base to let you know I'm taking a look at this one for you.

[TheRealAmazonKendra]

In unfortunate timing, we are fixing another pipeline issue.

[tomwwright]

Thanks @colifran @TheRealAmazonKendra, how did the pipeline run go?

[colifran]

@tomwwright we were having some other pipeline issues that should be resolved now. Just resubmitted this one to the test pipeline. Assuming everything passes, we can get this one merged in!

[aws-cdk-automation]

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

[colifran]

Great job with this and thanks for your patience!

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 85517d3
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).