Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uniform macos agents #1387

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Use uniform macos agents #1387

merged 5 commits into from
Apr 26, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Apr 26, 2024

Problem

actions/runner#3256 made macos-latest resolve OSX14 and ARM64 architecture.
But macos-latest-xl resolves to OSX12 and Intel still.
This created mismatch between steps. I.e. install step installs dependencies for ARM64, including native binaries and then other step running on large mac agent was trying to use them on Intel.

Issue number, if available:

Changes

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Apr 26, 2024
Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: 3a325c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk mentioned this pull request Apr 26, 2024
4 tasks
@sobolk sobolk marked this pull request as ready for review April 26, 2024 19:05
@sobolk sobolk changed the title Pin macos agents Use uniform macos agents Apr 26, 2024
@sobolk sobolk merged commit 6b54a10 into main Apr 26, 2024
37 of 39 checks passed
@sobolk sobolk deleted the pin-macos-agents branch April 26, 2024 19:28
@sobolk sobolk mentioned this pull request Apr 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants