Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uniform macos agents. #1386

Closed
wants to merge 2 commits into from
Closed

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Apr 26, 2024

Problem

actions/runner#3256 made macos-latest resolve OSX14 and ARM64 architecture.
But macos-latest-xl resolves to OSX12 and Intel still.
This created mismatch between steps. I.e. install step installs dependencies for ARM64, including native binaries and then other step running on large mac agent was trying to use them on Intel.

Issue number, if available:

Changes

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Apr 26, 2024
Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: a0d38b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sobolk
Copy link
Member Author

sobolk commented Apr 26, 2024

Closing in favor of #1387

@sobolk sobolk closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants