New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non ascii object members #153
Conversation
Sphinx expects utf8 and this may set to something different by default on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, thank you for the fix.
Could you please add an entry to the changelog (CHANGES.rst) to mention the bugfix? Thanks!
@bsipocz I had to remove your suggestion with the empty line as the test fail now. |
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 89.43% 89.31% -0.13%
==========================================
Files 23 24 +1
Lines 1098 1104 +6
==========================================
+ Hits 982 986 +4
- Misses 116 118 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Thank you @m-rossi! |
I just had an issue with non-ascii-characters in class members (in my case its a column name of a database I access with SQLAlchemy). This PR sets a default
encoding
foropen()
as the default seems to be os-dependent, howevers sphinx expectsutf8
. This fixes my issues on Windows.I also tried to modify the non-ascii-testcase, however this seems to pass without my fix. If I execute normal
sphinx-build
during command-line it fails: