-
-
Notifications
You must be signed in to change notification settings - Fork 48
Fix nonascii object names #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 28 28
Lines 1179 1179
=======================================
Hits 1064 1064
Misses 115 115 ☔ View full report in Codecov by Sentry. |
Thanks! LGTM but second pair of eyes won't hurt. Needs a change log: https://github.com/astropy/sphinx-automodapi/blob/main/CHANGES.rst |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM but I'll keep it open for a bit in case other devs want to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look all good, thank you so much @m-rossi!
One bike-shedding suggestion, take it or leave it.
.../cases/non_ascii/output/api/sphinx_automodapi.tests.example_module.nonascii.NonAsciiÄöüß.rst
Outdated
Show resolved
Hide resolved
.../cases/non_ascii/output/api/sphinx_automodapi.tests.example_module.nonascii.NonAsciiÄöüß.rst
Outdated
Show resolved
Hide resolved
sphinx_automodapi/tests/cases/non_ascii/output/index.rst.automodsumm
Outdated
Show resolved
Hide resolved
.../cases/non_ascii/output/api/sphinx_automodapi.tests.example_module.nonascii.NonAsciiÄöüß.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Thanks, all! |
@pllim may we can have a new release including this fix? |
Re: release -- @bsipocz , what do you think? Anything else we should fit it before release? |
Not sure how far #182 is from being finished, but either case, I'm not against tagging a release with what we have now. |
I pinged Nathaniel over there but I doubt it is ready to go. I can do a release tomorrow unless someone else beats me to it. (And please remind me if I forget!) |
OK, I'll try to see if I can get to it today, after all I'm already in release mode for other libs. |
@bsipocz , did you get to it? If not, I can probably do it too. Lemme know. Thanks! |
@bsipocz , I'll just go ahead with a release today. Don't worry about it. Thanks! |
@m-rossi , v0.17.0 is released. Thanks for your patience! |
Thanks, and sorry that I eventually didn't get to it sooner. |
As a follow up to #153 I recently had another issue with nonascii characters. This time its the object name itself, for example the class name.
This PR adds the most popular umlauts (äöüß) to the regular expressions.