Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonascii object names #184

Merged
merged 6 commits into from Feb 15, 2024
Merged

Fix nonascii object names #184

merged 6 commits into from Feb 15, 2024

Conversation

m-rossi
Copy link
Contributor

@m-rossi m-rossi commented Feb 14, 2024

As a follow up to #153 I recently had another issue with nonascii characters. This time its the object name itself, for example the class name.

This PR adds the most popular umlauts (äöüß) to the regular expressions.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04947b6) 90.24% compared to head (5ab68d0) 90.24%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          28       28           
  Lines        1179     1179           
=======================================
  Hits         1064     1064           
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim added the bug label Feb 14, 2024
@pllim pllim added this to the 0.17.0 milestone Feb 14, 2024
@pllim
Copy link
Member

pllim commented Feb 14, 2024

Thanks! LGTM but second pair of eyes won't hurt.

Needs a change log: https://github.com/astropy/sphinx-automodapi/blob/main/CHANGES.rst

@pllim pllim requested a review from bsipocz February 14, 2024 16:46
@m-rossi
Copy link
Contributor Author

m-rossi commented Feb 14, 2024

Needs a change log: https://github.com/astropy/sphinx-automodapi/blob/main/CHANGES.rst

Done.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM but I'll keep it open for a bit in case other devs want to review.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look all good, thank you so much @m-rossi!

One bike-shedding suggestion, take it or leave it.

m-rossi and others added 2 commits February 15, 2024 08:27
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
@pllim pllim merged commit 2963d43 into astropy:main Feb 15, 2024
17 checks passed
@pllim
Copy link
Member

pllim commented Feb 15, 2024

Thanks, all!

@m-rossi m-rossi deleted the more-nonascii-fixes branch February 15, 2024 18:31
@m-rossi
Copy link
Contributor Author

m-rossi commented Feb 20, 2024

@pllim may we can have a new release including this fix?

@pllim
Copy link
Member

pllim commented Feb 20, 2024

Re: release -- @bsipocz , what do you think? Anything else we should fit it before release?

@bsipocz
Copy link
Member

bsipocz commented Feb 20, 2024

Not sure how far #182 is from being finished, but either case, I'm not against tagging a release with what we have now.

@pllim
Copy link
Member

pllim commented Feb 20, 2024

I pinged Nathaniel over there but I doubt it is ready to go. I can do a release tomorrow unless someone else beats me to it. (And please remind me if I forget!)

@bsipocz
Copy link
Member

bsipocz commented Feb 20, 2024

OK, I'll try to see if I can get to it today, after all I'm already in release mode for other libs.

@pllim
Copy link
Member

pllim commented Feb 21, 2024

@bsipocz , did you get to it? If not, I can probably do it too. Lemme know. Thanks!

@pllim
Copy link
Member

pllim commented Feb 22, 2024

@bsipocz , I'll just go ahead with a release today. Don't worry about it. Thanks!

@pllim
Copy link
Member

pllim commented Feb 22, 2024

@m-rossi , v0.17.0 is released. Thanks for your patience!

@bsipocz
Copy link
Member

bsipocz commented Feb 23, 2024

Thanks, and sorry that I eventually didn't get to it sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants