Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect unneeded async keywords on functions #9966

Merged
merged 39 commits into from
Apr 16, 2024
Merged

Detect unneeded async keywords on functions #9966

merged 39 commits into from
Apr 16, 2024

Commits on Feb 12, 2024

  1. [ruff] Issue astral-sh#9951, RUF029: started implementation that de… 

    …tects an async function w/o await
    @plredmond
    plredmond committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    bd6ccde View commit details
    Browse the repository at this point in the history

  2. [ruff] Issue astral-sh#9951, RUF029: detect async function w/o awai… 

    …t or async_for or async_with
    @plredmond
    plredmond committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    dad3ee2 View commit details
    Browse the repository at this point in the history

  3. [ruff] Issue astral-sh#9951, RUF029: fix rust lister errors by remo… 

    …ving unused

imports
    @plredmond
    plredmond committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    71d908a View commit details
    Browse the repository at this point in the history

  4. [ruff] Issue astral-sh#9951, RUF029: add test to suite

    @plredmond
    plredmond committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    dc7260d View commit details
    Browse the repository at this point in the history

  5. [ruff] Issue astral-sh#9951, RUF029: documentation; examples do not… 

    … seem necessary for this rule
    @plredmond
    plredmond committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    44b70fe View commit details
    Browse the repository at this point in the history

  6. [ruff] Issue astral-sh#9951, RUF029: cargo dev generate-all and the… 

    …n accept the test snapshot
    @plredmond
    plredmond committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3b8f1be View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. [ruff] Issue astral-sh#9951, RUF029: cargo fmt

    @plredmond
    plredmond committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    8635433 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Merge branch 'main' into issue9951-spurious_async

    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b8af383 View commit details
    Browse the repository at this point in the history

  2. [ruff] Issue astral-sh#9951, RUF029: tweak language of test case co… 

    …mments
    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    6070957 View commit details
    Browse the repository at this point in the history

  3. [ruff] Issue astral-sh#9951, RUF029: tweak language about why it is… 

    … bad to have unused asyncs
    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    503c468 View commit details
    Browse the repository at this point in the history

  4. [ruff] Issue astral-sh#9951, RUF029: ruff format the RUF029.py fixture

    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    ff5023e View commit details
    Browse the repository at this point in the history

  5. [ruff] Issue astral-sh#9951, RUF029: add (small) example to spuriou… 

    …s async docs
    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b014a52 View commit details
    Browse the repository at this point in the history

  6. [ruff] Issue astral-sh#9951, RUF029: cargo insta review to accept… 

    … the reformatted RUF029 fixture output due to ff5023e
    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    65d85ed View commit details
    Browse the repository at this point in the history

  7. [ruff] Issue astral-sh#9951, RUF029: take the whole function as an … 

    …argument to avoid the posibility of wrong inputs per charlie
    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    700dd15 View commit details
    Browse the repository at this point in the history

  8. [ruff] Issue astral-sh#9951, RUF029: rename the field from found_fi… 

    …eld to found_await_or_yield
    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5dc2d9e View commit details
    Browse the repository at this point in the history

  9. [ruff] Issue astral-sh#9951, RUF029: two new pass and fail cases

    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    939ba6e View commit details
    Browse the repository at this point in the history

  10. [ruff] Issue astral-sh#9951, RUF029: one new pass test case

    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e53f2e7 View commit details
    Browse the repository at this point in the history

  11. [ruff] Issue astral-sh#9951, RUF029: change the test case that only… 

    … yields to a fail-case per @carljm (yield does not require async)
    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    4dce6c5 View commit details
    Browse the repository at this point in the history

  12. [ruff] Issue astral-sh#9951, RUF029: change comments and docstrings… 

    … to remove the word yield
    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b65f072 View commit details
    Browse the repository at this point in the history

  13. [ruff] Issue astral-sh#9951, RUF029: change identifiers to remove t… 

    …he word yield
    @plredmond
    plredmond committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2812646 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. [ruff] Issue astral-sh#9951, RUF029: format fixture for RUF029 test… 

    … and rename a fail-case
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c8ea017 View commit details
    Browse the repository at this point in the history

  2. [ruff] Issue astral-sh#9951, RUF029: reorganize test cases for RUF029

    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e087be2 View commit details
    Browse the repository at this point in the history

  3. [ruff] Issue astral-sh#9951, RUF029: switch to preorder visitor

    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1cb7765 View commit details
    Browse the repository at this point in the history

  4. [ruff] Issue astral-sh#9951, RUF029: report only the name of the fu… 

    …nction as the problem area
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f28fd87 View commit details
    Browse the repository at this point in the history

  5. [ruff] Issue astral-sh#9951, RUF029: skip the rest of traversal aft… 

    …er finding an async/await (per @MichaReiser)
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    41f0ac5 View commit details
    Browse the repository at this point in the history

  6. [ruff] Issue astral-sh#9951, RUF029: disable a test in RUF029 fixture

    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    473e7aa View commit details
    Browse the repository at this point in the history

  7. [ruff] Issue astral-sh#9951, RUF029: supplement the tests with asyn… 

    …cs inside asyncs (fail_4a, fail_4b) with tests having asyncs inside of normal functions (pass_5, fail_4c)
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e4abecb View commit details
    Browse the repository at this point in the history

  8. [ruff] Issue astral-sh#9951, RUF029: implement traversals of StmtFu… 

    …nctionDef and StmtClass def that do not traverse the body, use them in spurious async to avoid attributing correct /inner/ async functions to incorrect outer functions
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b714e80 View commit details
    Browse the repository at this point in the history

  9. [ruff] Issue astral-sh#9951, RUF029: clippy fixes

    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    59c9639 View commit details
    Browse the repository at this point in the history

  10. [ruff] Issue astral-sh#9951, RUF029: insta review

    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c5dd1b3 View commit details
    Browse the repository at this point in the history

  11. [ruff] Issue astral-sh#9951, RUF029: rename spurious-async to unuse… 

    …d-async
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c53b32f View commit details
    Browse the repository at this point in the history

  12. [ruff] Issue astral-sh#9951, RUF029: cosmetic change

    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    2694d4a View commit details
    Browse the repository at this point in the history

  13. [ruff] Issue astral-sh#9951, RUF029: add filter to avoid checking f… 

    …unctions in class definitions using semantic scope info (per @charliermarsh, and thanks to @MichaReiser)
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    717f884 View commit details
    Browse the repository at this point in the history

  14. [ruff] Issue astral-sh#9951, RUF029: insta review - the line number… 

    …s changed
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    10313fd View commit details
    Browse the repository at this point in the history

  15. [ruff] Issue astral-sh#9951, RUF029: cosmetic change to string

    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7f2af61 View commit details
    Browse the repository at this point in the history

  16. [ruff] Issue astral-sh#9951, RUF029: insta review - the string expl… 

    …anation has quotes
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    154d1f4 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'main' into issue9951-spurious_async

    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    fc9094e View commit details
    Browse the repository at this point in the history

  18. [ruff] Issue astral-sh#9951, RUF029: cargo dev generate-all - fix n… 

    …ewline
    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f17dea9 View commit details
    Browse the repository at this point in the history

  19. [ruff] Issue astral-sh#9951, RUF029: correct rule order in match

    @plredmond
    plredmond committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    212dfac View commit details
    Browse the repository at this point in the history