Detect unneeded `async` keywords on functions #9966

plredmond · 2024-02-13T00:00:59Z

Summary

This change adds a rule to detect functions declared async but lacking any of await, async with, or async for. This resolves #9951.

Test Plan

This change was tested by following https://docs.astral.sh/ruff/contributing/#rule-testing-fixtures-and-snapshots and adding positive and negative cases for each of await vs nothing, async with vs with, and async for vs for.

Questions/todo

I'm unsure whether the rule should also check for yield appearing in functions. My understanding is that there has been several rounds of iteration in how python async is supposed to be done, and that yield is not considered current, and so I haven't added a case for that. Therefore an async function containing only yield will cause this rule to fire.
- resolved by "async doesn't require yield" so the rule will fire when an async function's only async feature is yield
- Detect unneeded async keywords on functions #9966 (comment)
- Detect unneeded async keywords on functions #9966 (review)
I was unsure how to access just the range of the function declaration (without the body), so the rule currently indicates the whole function declaration & body as the problem area.
~~[ ] Needs review by @zanieb~~

…tects an async function w/o await

…t or async_for or async_with

…ving unused imports

… seem necessary for this rule

…n accept the test snapshot

plredmond · 2024-02-13T00:05:57Z

Sorry, I neglected formatting and linting of the rust code. I'll do that now.

github-actions · 2024-02-13T00:13:55Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+314 -0 violations, +0 -0 fixes in 5 projects; 39 projects unchanged)

DisnakeDev/disnake (+65 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ disnake/ext/commands/core.py:1722:19: RUF029 Function `wrapper` is declared `async`, but doesn't `await` or use `async` features.
+ disnake/utils.py:522:11: RUF029 Function `_assetbytes_to_base64_data` is declared `async`, but doesn't `await` or use `async` features.
+ disnake/utils.py:527:11: RUF029 Function `_assetbytes_to_base64_data` is declared `async`, but doesn't `await` or use `async` features.
+ examples/basic_bot.py:81:11: RUF029 Function `on_ready` is declared `async`, but doesn't `await` or use `async` features.
+ examples/basic_voice.py:136:11: RUF029 Function `on_ready` is declared `async`, but doesn't `await` or use `async` features.
+ examples/converters.py:77:11: RUF029 Function `on_ready` is declared `async`, but doesn't `await` or use `async` features.
+ examples/edit_delete.py:52:11: RUF029 Function `on_ready` is declared `async`, but doesn't `await` or use `async` features.
+ examples/guessing_game.py:39:11: RUF029 Function `on_ready` is declared `async`, but doesn't `await` or use `async` features.
+ examples/interactions/autocomplete.py:25:11: RUF029 Function `autocomplete_langs` is declared `async`, but doesn't `await` or use `async` features.
+ examples/interactions/autocomplete.py:31:11: RUF029 Function `languages_1` is declared `async`, but doesn't `await` or use `async` features.
... 55 additional changes omitted for project

RasaHQ/rasa (+168 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ rasa/core/channels/botframework.py:293:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/callback.py:68:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/console.py:106:11: RUF029 Function `_get_user_input` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/console.py:111:11: RUF029 Function `_get_user_input` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/facebook.py:359:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/facebook.py:363:19: RUF029 Function `token_verification` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/hangouts.py:295:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/mattermost.py:208:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/rest.py:138:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/rocketchat.py:148:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/slack.py:503:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/socketio.py:198:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/socketio.py:202:19: RUF029 Function `connect` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/socketio.py:220:19: RUF029 Function `disconnect` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/telegram.py:202:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/twilio.py:126:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/twilio_voice.py:233:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/channels/webexteams.py:102:19: RUF029 Function `health` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/jobs.py:13:11: RUF029 Function `scheduler` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/run.py:129:15: RUF029 Function `configure_async_logging` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/run.py:292:11: RUF029 Function `create_connection_pools` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/core/training/interactive.py:1630:15: RUF029 Function `ignore_404s` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/server.py:1264:15: RUF029 Function `tracker_predict` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/server.py:1365:15: RUF029 Function `unload_model` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/server.py:1376:15: RUF029 Function `get_domain` is declared `async`, but doesn't `await` or use `async` features.
+ rasa/server.py:403:11: RUF029 Function `authenticate` is declared `async`, but doesn't `await` or use `async` features.
... 142 additional changes omitted for project

apache/airflow (+12 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ tests/providers/apache/livy/hooks/test_livy.py:508:19: RUF029 Function `mock_fun` is declared `async`, but doesn't `await` or use `async` features.
+ tests/providers/apache/livy/hooks/test_livy.py:531:19: RUF029 Function `mock_fun` is declared `async`, but doesn't `await` or use `async` features.
+ tests/providers/apache/livy/hooks/test_livy.py:556:19: RUF029 Function `mock_fun` is declared `async`, but doesn't `await` or use `async` features.
+ tests/providers/apache/livy/hooks/test_livy.py:597:19: RUF029 Function `mock_fun` is declared `async`, but doesn't `await` or use `async` features.
+ tests/providers/apache/livy/hooks/test_livy.py:616:19: RUF029 Function `mock_fun` is declared `async`, but doesn't `await` or use `async` features.
+ tests/providers/cncf/kubernetes/triggers/test_pod.py:76:15: RUF029 Function `mock_read_namespaced_pod` is declared `async`, but doesn't `await` or use `async` features.
+ tests/providers/google/cloud/hooks/test_cloud_batch.py:322:19: RUF029 Function `_get_job` is declared `async`, but doesn't `await` or use `async` features.
+ tests/providers/google/cloud/hooks/test_dataproc.py:68:11: RUF029 Function `mock_awaitable` is declared `async`, but doesn't `await` or use `async` features.
+ tests/providers/google/cloud/triggers/test_cloud_batch.py:137:19: RUF029 Function `_mock_job` is declared `async`, but doesn't `await` or use `async` features.
+ tests/providers/google/cloud/triggers/test_cloud_run.py:109:19: RUF029 Function `_mock_operation` is declared `async`, but doesn't `await` or use `async` features.
... 2 additional changes omitted for project

python/typeshed (+65 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select E,F,FA,I,PYI,RUF,UP,W

+ stdlib/asyncio/staggered.pyi:8:11: RUF029 Function `staggered_race` is declared `async`, but doesn't `await` or use `async` features.
+ stdlib/asyncio/streams.pyi:29:15: RUF029 Function `open_connection` is declared `async`, but doesn't `await` or use `async` features.
+ stdlib/asyncio/streams.pyi:37:15: RUF029 Function `start_server` is declared `async`, but doesn't `await` or use `async` features.
+ stdlib/asyncio/streams.pyi:48:15: RUF029 Function `open_connection` is declared `async`, but doesn't `await` or use `async` features.
+ stdlib/asyncio/streams.pyi:57:15: RUF029 Function `start_server` is declared `async`, but doesn't `await` or use `async` features.
+ stdlib/asyncio/streams.pyi:70:19: RUF029 Function `open_unix_connection` is declared `async`, but doesn't `await` or use `async` features.
+ stdlib/asyncio/streams.pyi:73:19: RUF029 Function `start_unix_server` is declared `async`, but doesn't `await` or use `async` features.
+ stdlib/asyncio/streams.pyi:77:19: RUF029 Function `open_unix_connection` is declared `async`, but doesn't `await` or use `async` features.
+ stdlib/asyncio/streams.pyi:80:19: RUF029 Function `start_unix_server` is declared `async`, but doesn't `await` or use `async` features.
+ stdlib/asyncio/subprocess.pyi:104:15: RUF029 Function `create_subprocess_shell` is declared `async`, but doesn't `await` or use `async` features.
... 55 additional changes omitted for project

zulip/zulip (+4 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ zerver/lib/push_notifications.py:183:15: RUF029 Function `err_func` is declared `async`, but doesn't `await` or use `async` features.
+ zerver/lib/push_notifications.py:188:15: RUF029 Function `make_apns` is declared `async`, but doesn't `await` or use `async` features.
+ zerver/tornado/event_queue.py:687:11: RUF029 Function `setup_event_queue` is declared `async`, but doesn't `await` or use `async` features.
+ zerver/tornado/views.py:42:15: RUF029 Function `wrapped` is declared `async`, but doesn't `await` or use `async` features.

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
RUF029	314	314	0	0	0

crates/ruff_linter/resources/test/fixtures/ruff/RUF029.py

zanieb · 2024-02-13T00:52:27Z

The rasa ecosystem checks look like a bunch of false positives due to methods that are overriding an abstract method which must be async. This common enough that we should attempt to avoid it, but it requires multifile analysis in most cases which we do not yet support yet. There are some other issues like this, but I can't recall them — perhaps @charliermarsh knows. We could consider just not applying this to methods in classes with base classes for now?

charliermarsh · 2024-02-13T00:54:45Z

Ah yeah, the thing we often do there (at the very least) is check if the method has an @override decorator (can grep for is_override), since that's used to hint to static analysis tools that the method doesn't have control over its own signature. So users at least have a way to opt-out of these kinds of rules entirely for methods that override a parent method. I would be fine omitting this entirely for classes with base classes though (or even classes at all?).

zanieb · 2024-02-13T00:55:43Z

Here's another interesting edge-case false positive https://github.com/zulip/zulip/blob/35098f49597895718343091881fbd6198bd2022d/zerver/tornado/views.py#L35 — this one I'm less sure we can/should do anything about.

crates/ruff_linter/src/rules/ruff/rules/spurious_async.rs

charliermarsh

Nice!

crates/ruff_linter/resources/test/fixtures/ruff/RUF029.py

crates/ruff_linter/src/checkers/ast/analyze/statement.rs

charliermarsh · 2024-02-13T01:04:56Z

crates/ruff_linter/src/rules/ruff/rules/spurious_async.rs

+            SpuriousAsync {
+                name: name.to_string(),
+            },
+            range,


Ahh, if you have the function_def: &ast::StmtFunctionDef as an argument to this method, you can use function_def.identifier() to get just the range of the function name (per your PR summary).

Is it desirable for the error message to only indicate the name, given that the problem is to the left of the name (the use of the async keyword) and to the right of it (the function body lacking a reason for the use of the async keyword)?

zanieb · 2024-02-13T01:15:10Z

Perhaps @AlexWaygood can elucidate whether or not this should trigger for functions with yield.

https://peps.python.org/pep-0525 may be helpful.

crates/ruff_linter/src/rules/ruff/rules/spurious_async.rs

AlexWaygood · 2024-02-13T16:48:36Z

Perhaps @AlexWaygood can elucidate whether or not this should trigger for functions with yield.

peps.python.org/pep-0525 may be helpful.

Yeah, async functions that contain yield are async generators that can be used in async for loops by other async functions. So I don't think ruff should emit this diagnostic for async functions that have a yield in them:

>>> import asyncio
>>> async def x():
...     yield 42
...     yield 56
...
>>> x
<function x at 0x00000274CDC52200>
>>> x()
<async_generator object x at 0x00000274CC36BE20>
>>> async def y():
...     async for number in x():
...         print(number)
...
>>> asyncio.run(y())
42
56

MichaReiser · 2024-02-13T18:48:34Z

I think there's one issue that we might need to look into and it's that the visitor will cross function boundaries when searching for await and yield, resulting in false negatives

async def unnecessary_async():
	async def inner():
		await x

async def unnecessary_async2():
	class Inner:
		async def inner():	
			await x

I don't think the rule flags unnecessary_async or unnecessary_async2.

plredmond · 2024-02-13T18:50:11Z

Thanks for your review! I've looked over the comments above and can work on the changes later today. I need to devote this morning to a different task.

Ah yeah, the thing we often do there (at the very least) is check if the method has an @override decorator (can grep for is_override), since that's used to hint to static analysis tools that the method doesn't have control over its own signature. So users at least have a way to opt-out of these kinds of rules entirely for methods that override a parent method. I would be fine omitting this entirely for classes with base classes though (or even classes at all?).

@charliermarsh should I omit this check in both the cases (1) in the context of a class or (2) when the override decorator is present? Based on your description, it seems preferable to limit case (1) to classes with a base class, since they're actually likely to be overriding things, though.

plredmond · 2024-02-13T19:05:46Z

I don't think the rule flags unnecessary_async or unnecessary_async2.

@MichaReiser These examples make the problem a bit harder. 🙂 I need to check if the visitor has a callback for when an inner-function ends; I could use that to track which scope I'm in when detecting yielding-expressions to attribute them correctly.

MichaReiser · 2024-02-13T20:36:47Z

@plredmond I think there are only two cases where this is relevant: classes and functions. You could extend your visitor to handle visit_stmt explicitly and traverse classes and functions manually (don't call walk_stmt). This allows you to skip traversing the body (you still want to traverse decorators and the function header)

plredmond · 2024-03-05T05:56:06Z

Hi! Sorry to let this PR languish. I have a paper deadline just before I start my astral internship, so I have to put this on ice until then.

MichaReiser · 2024-04-05T10:29:27Z

IMO, unused-async is easier to understand than spurious (which I mainly associate with threading). It also fits well into other rules that catch "unused" syntax.

AlexWaygood · 2024-04-09T09:16:16Z

Yeah, async functions that contain yield are async generators that can be used in async for loops by other async functions. So I don't think ruff should emit this diagnostic for async functions that have a yield in them:

So, I chatted to @carljm about this offline... and he persuaded me that the rationale I gave in #9966 (comment) for excluding async generators from this check basically makes no sense :-)

It's true that removing the async keyword from a function with a yield statement in it will mean that it will become a sync generator function rather than an async generator function. That means that it will only be usable in for loops, not async for loops, which means callsites of the function will have to be rewritten to use for loops rather than async for loops -- potentially a sweeping and disruptive refactor. However... that's not really materially different from the changes this rule recommends to non-generator functions. Removing redundant async keywords from non-generator functions that don't have any awaits in them will also necessitate callsites being refactored: you'll have to do this refactor everywhere:

- x = await function_in_question()
+ x = function_in_question()

As such, I'm now persuaded that there's no reason to exclude async generator functions from this check. (Thanks @carljm!)

plredmond · 2024-04-15T16:45:00Z

Picking this up today. Sorry for the delay.

…mments

plredmond · 2024-04-15T19:19:28Z

IMO, unused-async is easier to understand than spurious (which I mainly associate with threading). It also fits well into other rules that catch "unused" syntax.

Saving this rename for last b/c it'll disrupt the above comments on diffs.

plredmond · 2024-04-16T07:16:09Z

Ok, I think everything is done except for this:

However, this doesn't cover @charliermarsh's suggestion to just omit checking methods in classes. I'm not sure how to approach that (and the test case is commented out). The rule is currently written in terms of a function definition; to omit the rule for methods, we'd need to know whether that function definition is a method. I didn't see a way to do that in analyze/statement.rs.

[EDIT: I'll look at the test failure in the morning. I don't see one when I test locally.]

MichaReiser · 2024-04-16T07:51:43Z

@plredmond I'm not entirely sure if that's what you mean but you can test if you're inside a class by using

    // Assignments in class bodies are attributes (e.g., `x = x` assigns `x` to `self.x`, and thus
    // is not a self-assignment).
    if checker.semantic().current_scope().kind.is_class() {
        return;
    }

You can also use the kind to retrieve more information about the enclosing class (e.g. if it has any base class or whatnot)

kkom · 2024-04-16T09:38:00Z

Came across this PR when looking at #9951 – thank you for adding this rule, very excited about it!

Regarding the latest discussion – I'm curious why not omit it for method marked with @override and continue linting methods? This is analogous to how https://docs.astral.sh/ruff/rules/no-self-use/ works – and that rule has worked really well for us in that way.

zanieb · 2024-04-16T14:16:37Z

@kkom we're just cutting scope from the initial rule. We could consider it in the future.

charliermarsh · 2024-04-16T16:42:35Z

This looks good to me, but I suggest adding the snippet that Micha posted above.

crates/ruff_linter/src/rules/ruff/rules/unused_async.rs

@charliermarsh

…unctions in class definitions using semantic scope info (per @charliermarsh, and thanks to @MichaReiser)

…s changed

…anation has quotes

charliermarsh · 2024-04-16T17:05:23Z

@plredmond - Try running cargo dev generate-all -- you need to regenerate the JSON Schema since we added a new rule.

charliermarsh · 2024-04-16T17:05:35Z

(I believe that's the cause of your failing test.)

plredmond · 2024-04-16T17:08:21Z

$ cargo dev generate-all
...
$ git diff
diff --git a/ruff.schema.json b/ruff.schema.json
index 871cce40b..90582fc67 100644
--- a/ruff.schema.json
+++ b/ruff.schema.json
@@ -3951,4 +3951,4 @@
       ]
     }
   }
-}
+}
\ No newline at end of file

charliermarsh · 2024-04-16T17:09:08Z

Is your editor adding a newline?

plredmond · 2024-04-16T17:09:28Z

I also tried fetching and merging in the latest main in. Still no success. Strangely, I'm not seeing this locally.

I'll look at the CI output.

plredmond · 2024-04-16T17:10:26Z

Is your editor adding a newline?

It was modified by cargo dev generate-all afaik. My editor is vim and I didn't modify that file.

charliermarsh · 2024-04-16T17:11:09Z

We do expect the Schema to change on this branch.

…ewline

plredmond · 2024-04-16T17:14:04Z

I was wrong. I did edit it, back in feb, and that seems to have lead to the CI complaining about the newline. It should be fixed now.

crates/ruff_linter/src/codes.rs

plredmond added 6 commits February 12, 2024 14:33

[ruff] Issue astral-sh#9951, RUF029: started implementation that de…

bd6ccde

…tects an async function w/o await

[ruff] Issue astral-sh#9951, RUF029: detect async function w/o awai…

dad3ee2

…t or async_for or async_with

[ruff] Issue astral-sh#9951, RUF029: fix rust lister errors by remo…

71d908a

…ving unused imports

[ruff] Issue astral-sh#9951, RUF029: add test to suite

dc7260d

[ruff] Issue astral-sh#9951, RUF029: documentation; examples do not…

44b70fe

… seem necessary for this rule

[ruff] Issue astral-sh#9951, RUF029: cargo dev generate-all and the…

3b8f1be

…n accept the test snapshot

[ruff] Issue astral-sh#9951, RUF029: cargo fmt

8635433

zanieb reviewed Feb 13, 2024

View reviewed changes

crates/ruff_linter/resources/test/fixtures/ruff/RUF029.py Outdated Show resolved Hide resolved

zanieb reviewed Feb 13, 2024

View reviewed changes

crates/ruff_linter/src/rules/ruff/rules/spurious_async.rs Outdated Show resolved Hide resolved

charliermarsh reviewed Feb 13, 2024

View reviewed changes

MichaReiser reviewed Feb 13, 2024

View reviewed changes

MichaReiser added the accepted Ready for implementation label Apr 5, 2024

plredmond added 2 commits April 15, 2024 12:06

Merge branch 'main' into issue9951-spurious_async

b8af383

[ruff] Issue astral-sh#9951, RUF029: tweak language of test case co…

6070957

…mments

[ruff] Issue astral-sh#9951, RUF029: cosmetic change

2694d4a

charliermarsh reviewed Apr 16, 2024

View reviewed changes

crates/ruff_linter/src/rules/ruff/rules/unused_async.rs Outdated Show resolved Hide resolved

plredmond added 5 commits April 16, 2024 09:44

[ruff] Issue astral-sh#9951, RUF029: add filter to avoid checking f…

717f884

…unctions in class definitions using semantic scope info (per @charliermarsh, and thanks to @MichaReiser)

[ruff] Issue astral-sh#9951, RUF029: insta review - the line number…

10313fd

…s changed

[ruff] Issue astral-sh#9951, RUF029: cosmetic change to string

7f2af61

[ruff] Issue astral-sh#9951, RUF029: insta review - the string expl…

154d1f4

…anation has quotes

Merge branch 'main' into issue9951-spurious_async

fc9094e

[ruff] Issue astral-sh#9951, RUF029: cargo dev generate-all - fix n…

f17dea9

…ewline

charliermarsh reviewed Apr 16, 2024

View reviewed changes

crates/ruff_linter/src/codes.rs Outdated Show resolved Hide resolved

charliermarsh approved these changes Apr 16, 2024

View reviewed changes

[ruff] Issue astral-sh#9951, RUF029: correct rule order in match

212dfac

plredmond mentioned this pull request Apr 16, 2024

RUF029 (unneeded async) needs nuance for class methods #10980

Open

plredmond merged commit 65edbfe into astral-sh:main Apr 16, 2024
17 checks passed

plredmond deleted the issue9951-spurious_async branch April 16, 2024 17:32

dhruvmanila added rule Implementing or modifying a lint rule preview Related to preview mode features labels Apr 18, 2024

BrewTestBot mentioned this pull request Apr 18, 2024

ruff 0.4.0 Homebrew/homebrew-core#169465

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect unneeded `async` keywords on functions #9966

Detect unneeded `async` keywords on functions #9966

plredmond commented Feb 13, 2024 •

edited

plredmond commented Feb 13, 2024

github-actions bot commented Feb 13, 2024 •

edited

zanieb commented Feb 13, 2024

charliermarsh commented Feb 13, 2024

zanieb commented Feb 13, 2024

charliermarsh left a comment

charliermarsh Feb 13, 2024

plredmond Apr 15, 2024

zanieb commented Feb 13, 2024 •

edited

AlexWaygood commented Feb 13, 2024

MichaReiser commented Feb 13, 2024

plredmond commented Feb 13, 2024

plredmond commented Feb 13, 2024

MichaReiser commented Feb 13, 2024

plredmond commented Mar 5, 2024

MichaReiser commented Apr 5, 2024 •

edited

AlexWaygood commented Apr 9, 2024

plredmond commented Apr 15, 2024

plredmond commented Apr 15, 2024 •

edited

plredmond commented Apr 16, 2024 •

edited

MichaReiser commented Apr 16, 2024

kkom commented Apr 16, 2024

zanieb commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

plredmond commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

plredmond commented Apr 16, 2024

plredmond commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

plredmond commented Apr 16, 2024

Detect unneeded async keywords on functions #9966

Detect unneeded async keywords on functions #9966

Conversation

plredmond commented Feb 13, 2024 • edited

Summary

Test Plan

Questions/todo

plredmond commented Feb 13, 2024

github-actions bot commented Feb 13, 2024 • edited

ruff-ecosystem results

Linter (stable)

Linter (preview)

zanieb commented Feb 13, 2024

charliermarsh commented Feb 13, 2024

zanieb commented Feb 13, 2024

charliermarsh left a comment

Choose a reason for hiding this comment

charliermarsh Feb 13, 2024

Choose a reason for hiding this comment

plredmond Apr 15, 2024

Choose a reason for hiding this comment

zanieb commented Feb 13, 2024 • edited

AlexWaygood commented Feb 13, 2024

MichaReiser commented Feb 13, 2024

plredmond commented Feb 13, 2024

plredmond commented Feb 13, 2024

MichaReiser commented Feb 13, 2024

plredmond commented Mar 5, 2024

MichaReiser commented Apr 5, 2024 • edited

AlexWaygood commented Apr 9, 2024

plredmond commented Apr 15, 2024

plredmond commented Apr 15, 2024 • edited

plredmond commented Apr 16, 2024 • edited

MichaReiser commented Apr 16, 2024

kkom commented Apr 16, 2024

zanieb commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

plredmond commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

plredmond commented Apr 16, 2024

plredmond commented Apr 16, 2024

charliermarsh commented Apr 16, 2024

plredmond commented Apr 16, 2024

Detect unneeded `async` keywords on functions #9966

Detect unneeded `async` keywords on functions #9966

plredmond commented Feb 13, 2024 •

edited

github-actions bot commented Feb 13, 2024 •

edited

`ruff-ecosystem` results

zanieb commented Feb 13, 2024 •

edited

MichaReiser commented Apr 5, 2024 •

edited

plredmond commented Apr 15, 2024 •

edited

plredmond commented Apr 16, 2024 •

edited