F821, F822: fix false positive for .pyi files; add more test coverage for .pyi files
#10341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge for `.pyi` files
|
Unfortunately typeshed already has F821 switched off in its config file due to this bug, or we'd likely see some changes here |
charliermarsh
approved these changes
Mar 11, 2024
This was referenced Mar 12, 2024
charliermarsh
added a commit
that referenced
this pull request
Mar 21, 2024
## Summary In #10341, we fixed some false positives in `.pyi` files, but introduced others. This PR effectively reverts the change in #10341 and fixes it in a slightly different way. Instead of changing the _bindings_ we generate in the semantic model in `.pyi` files, we instead change how we _resolve_ them. Closes #10509.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the following false positive in a
.pyistub file:In a
.pyfile, this is invalid regardless of whetherfrom __future__ import annotationsis enabled or not. In a.pyistub file, however, it's always valid, as an annotation counts as a binding in a stub file even if no value is assigned to the variable.I also added more test coverage for
.pyistub files in various edge cases where ruff's behaviour is currently correct, but where.pyistub files do slightly different things to.pyfiles. In the process of doing this, I discovered #10340.Test Plan
cargo test