Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select more rules for typeshed in the ecosystem checks #10564

Merged
merged 1 commit into from Mar 25, 2024

Conversation

AlexWaygood
Copy link
Member

Summary

This PR selects more rules for typeshed in the ecosystem checks, bringing the configuration slightly closer to the (somewhat complex) ruff config typeshed now uses in CI for .pyi files: https://github.com/python/typeshed/blob/f337eb8a5149a05528d19605b7ddd0bc9b5125e4/pyproject.toml#L26-L149. In particular, having F selected would have prevented #10509 from occuring, as the regression would have showed up in the ecosystem comment before I merged the PR that caused the regression (#10341).

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser added the ci Related to internal CI tooling label Mar 25, 2024
@AlexWaygood AlexWaygood merged commit 59ac3f4 into main Mar 25, 2024
17 checks passed
@AlexWaygood AlexWaygood deleted the ecosystem-typeshed branch March 25, 2024 14:04
@zanieb
Copy link
Member

zanieb commented Mar 25, 2024

No harm to just select ALL on more repositories too.

@AlexWaygood
Copy link
Member Author

No harm to just select ALL on more repositories too.

I wondered about it, but there's a risk that some categories (e.g. flake8-bugbear) that only really make sense for .py files might be quite noisy if we ran them on typeshed in the ecosystem checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants