Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2139] Raise plexus-java to 1.1.2 for proper Java 19/20 bytecode support #591

Merged
merged 2 commits into from Jan 2, 2023

Conversation

andpab
Copy link
Contributor

@andpab andpab commented Dec 30, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could/should change to use the asm bom.

@andpab
Copy link
Contributor Author

andpab commented Dec 31, 2022

We could/should change to use the asm bom.

Done.

I've also added a commit to replace JDK18 which is EOL by now with JDK19 in the builds, partly to demonstrate that it works with the changes I made. If that build-related change shouldn't be part of this PR, then let me know and I'll drop it.

@andpab
Copy link
Contributor Author

andpab commented Dec 31, 2022

Well, it's good I did that, because silly me forgot to add the import scope to the asm-bom dependency at first.

Now we should be good.

@andpab
Copy link
Contributor Author

andpab commented Jan 1, 2023

Thankfully, @slachiewicz has just released a new version of plexus-java which brings asm 9.4. So I'm going to simplify the pull request and just update the plexus-java.version property to 1.1.2 instead.

@andpab andpab changed the title [SUREFIRE-2139] Raise asm to 9.4 for proper Java 19/20 bytecode support [SUREFIRE-2139] Raise plexus-java to 1.1.2 for proper Java 19/20 bytecode support Jan 1, 2023
@slawekjaranowski slawekjaranowski merged commit 0c35f44 into apache:master Jan 2, 2023
@slawekjaranowski slawekjaranowski added dependencies Pull requests that update a dependency file enhancement and removed dependencies Pull requests that update a dependency file labels Jan 2, 2023
@andpab andpab mentioned this pull request Jan 2, 2023
@andpab andpab deleted the SUREFIRE-2139 branch January 2, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants