Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jdk 19 #565

Closed
wants to merge 2 commits into from
Closed

add jdk 19 #565

wants to merge 2 commits into from

Conversation

olamy
Copy link
Member

@olamy olamy commented Sep 21, 2022

No description provided.

@andpab
Copy link
Contributor

andpab commented Dec 30, 2022

I rebased this branch to master in my fork and ran the ITs. Most of them are successful except for 6 JPMS-related ITs:

  • MultiModuleProjectWithJPMSIT
  • Surefire1570ModularFailsafeIT
  • Surefire1712ExtractedModulenameWithoutASMIT
  • Surefire1733JUnitIT
  • Surefire1733TestngIT
  • Surefire1993JpmsProvidingModulesIT

They fail because the modules are not detected.

Changing the maven.compiler.release property from 19 to 18 in the test projects made the tests succeed. Looked like Surefire having a problem with JDK19-level bytecode for projects using JPMS, so I checked the dependency tree. It has ASM in version 9.2, coming in transitively via plexus-java-1.1.1. ASM 9.2 does not support JDK19 byte code.

I set ASM to 9.4 in the dependencyManagement section of the main pom.xml and the ITs were successful.

I've created a JIRA issue for it which also documents the two options for fixing the issue: SUREFIRE-2139

@andpab
Copy link
Contributor

andpab commented Jan 2, 2023

@olamy The changes from this pull request are included in the pull request #591 for SUREFIRE-2139 that was just merged to master, so I think this pull request and branch can be deleted.

@olamy olamy closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants