[SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe #570
Conversation
|
Relates to https://issues.apache.org/jira/browse/SUREFIRE-1910, fixes https://issues.apache.org/jira/browse/SUREFIRE-2119. |
liry
force-pushed
the
SUREFIRE-2119
branch
2 times, most recently
from
c9ac8f9
to
24b53db
Compare
| * Set this to "true" to cause a failure if none of the tests specified in -Dit.test=... are run. Defaults to | ||
| * "true". | ||
| * Replacing "it.failIfNoSpecifiedTests" to be consistent with surefire plugin. |
There was a problem hiding this comment.
as true is the default value, I would start documentation from something like
Set this to false to prevent a failure if none ....
There was a problem hiding this comment.
I agree with your suggestion, but @liry did not change the wording here.
Since there's no response from @liry, can the PR be merged anyway? In my fork I've rebased the branch to master. Builds were successful: https://github.com/andpab/maven-surefire/actions/runs/4198008135
After the merge of this one I could make a new PR that adjusts the wording according to your suggestion.
There was a problem hiding this comment.
Sorry, I somehow missed the first comment. Wording changed.
Surefire is using `surefire.failIfNoSpecifiedTests`, but failsafe used `it.failIfNoSpecifiedTests`. Error msg is then pointed to nonexistent property: `No tests matching pattern "..." were executed! (Set -Dfailsafe.failIfNoSpecifiedTests=false to ignore this error.)`
| getConsoleLogger().warning( "Use " + getPluginName() | ||
| + ".failIfNoSpecifiedTests property instead of obsolete it.failIfNoSpecifiedTests." ); |
There was a problem hiding this comment.
Maven 3.9 will print such info itself - but can be now.
Surefire is using
surefire.failIfNoSpecifiedTests, but failsafe usedit.failIfNoSpecifiedTests.Error msg is then pointed to nonexistent property:
No tests matching pattern "..." were executed! (Set -Dfailsafe.failIfNoSpecifiedTests=false to ignore this error.)Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
SUREFIRE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.