Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAVADOC-763] remove test that doesn't test what it claims #219

Merged
merged 1 commit into from Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -37,6 +37,7 @@
import org.apache.maven.plugin.LegacySupport;
import org.apache.maven.plugin.MojoExecution;
import org.apache.maven.plugin.MojoExecutionException;
import org.apache.maven.plugin.MojoFailureException;
import org.apache.maven.plugin.testing.AbstractMojoTestCase;
import org.apache.maven.plugin.testing.stubs.MavenProjectStub;
import org.apache.maven.plugins.javadoc.ProxyServer.AuthAsyncProxyServlet;
Expand Down Expand Up @@ -594,27 +595,6 @@ public void testOptionsUmlautEncoding() throws Exception {
}
}

/**
* @throws Exception if any
*/
public void testExceptions() throws Exception {
try {
Path testPom = unit.resolve("default-configuration/exception-test-plugin-config.xml");
JavadocReport mojo = lookupMojo(testPom);
slachiewicz marked this conversation as resolved.
Show resolved Hide resolved
mojo.execute();

fail("Must throw exception.");
} catch (Exception e) {
assertTrue(true);

try {
deleteDirectory(new File(getBasedir(), "exception"));
} catch (IOException ie) {
// nop
}
}
}

/**
* Method to test the taglet artifact configuration
*
Expand Down Expand Up @@ -821,8 +801,6 @@ public void testHeaderFooter() throws Exception {
} catch (MojoExecutionException e) {
fail("Doesnt handle correctly newline for header or footer parameter");
}

assertTrue(true);
}

/**
Expand All @@ -838,8 +816,6 @@ public void testNewline() throws Exception {
} catch (MojoExecutionException e) {
fail("Doesn't handle correctly newline for string parameters. See options and packages files.");
}

assertTrue(true);
}

/**
Expand Down Expand Up @@ -1167,8 +1143,7 @@ public void testStylesheetfile() throws Exception {
try {
mojo.execute();
fail();
} catch (Exception e) {
assertTrue(true);
} catch (MojoExecutionException | MojoFailureException e) {
}

// stylesheet == java
Expand Down

This file was deleted.