Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MJAVADOC-763] remove test that doesn't test what it claims #219

Merged
merged 1 commit into from Aug 14, 2023
Merged

[MJAVADOC-763] remove test that doesn't test what it claims #219

merged 1 commit into from Aug 14, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jul 10, 2023

And clean up other tests to prevent accidental pass or fail

@elharo elharo requested a review from michael-o July 10, 2023 11:22
@michael-o michael-o removed their request for review July 10, 2023 20:11
@elharo elharo requested a review from michael-o July 13, 2023 12:59
@michael-o michael-o removed their request for review July 14, 2023 10:50
@michael-o
Copy link
Member

I don't have an opinion here

@elharo elharo requested a review from gnodet July 14, 2023 11:28
@elharo elharo merged commit b4da86e into master Aug 14, 2023
52 checks passed
@elharo elharo deleted the assertTrue branch August 14, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

@gnodet gnodet Awaiting requested review from gnodet

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
4 participants
@elharo @michael-o @slachiewicz @slawekjaranowski