feat(trait): Add maven profile to Integration in builder trait #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jul 13, 2023
gansheer
force-pushed
the
feat/4560_maven_profile
branch
from
bce0c9d
to
7693b52
Compare
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
1 similar comment
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
squakez
reviewed
Jul 13, 2023
gansheer
force-pushed
the
feat/4560_maven_profile
branch
from
7693b52
to
21dd232
Compare
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
gansheer
force-pushed
the
feat/4560_maven_profile
branch
from
21dd232
to
845b90b
Compare
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
squakez
approved these changes
Jul 25, 2023
Ref apache#4560 * Add builder.maven-profile property referencing a secret or a configmap * Inject the given profile into the pom.xml generated * Some refactoring on configmap/secret decoding from cli
gansheer
force-pushed
the
feat/4560_maven_profile
branch
from
845b90b
to
0f30d73
Compare
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
|
All green. Is there any other pending work or can we merge @gansheer? |
|
It's complete, ready for merge 🎇 . |
|
Thanks for the contribution. Consider to add some documentation to show usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4560
Description
[configmap|secret]:name[/key]Example:
kubectl create secret generic maven-profile-owasp --from-file=owasp-profile.xml-t builder.maven-profile=secret:maven-profile-owasp/owasp-profile.xmlRelease Note