Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kamelet - Inject secret in Azure KeyVault Trait #4743

Closed
jorgebg90 opened this issue Sep 14, 2023 · 2 comments · Fixed by #4799
Closed

Kamelet - Inject secret in Azure KeyVault Trait #4743

jorgebg90 opened this issue Sep 14, 2023 · 2 comments · Fixed by #4799
Assignees
Labels
area/traits kind/feature New feature or request

Comments

@jorgebg90
Copy link

Requirement

As a User
I want to be able to use a configmap/secret in azure-key-vault.client-secret field for Azure KeyVault trait
When I deploy a Kamelet Integration / Kamelet pipe in order to hide the real Azure Key Vault credentials.

Problem

When I was trying to deploy my current Kamelet Pipe into our cluster through Github repository I realize that I couldn't hide the azure-key-vault.client-secret through a secret or configmap:

apiVersion: camel.apache.org/v1
kind: Pipe
metadata:
  namespace: default
  name: currentPipe
  annotations:
    trait.camel.apache.org/logging.level: DEBUG
    trait.camel.apache.org/azure-key-vault.enabled: "true"
    trait.camel.apache.org/azure-key-vault.tenant-id: "aaaa-bbbb-ccc-ddd-eee"
    trait.camel.apache.org/azure-key-vault.vault-name: "currentvaultName"
    trait.camel.apache.org/azure-key-vault.client-id: "azurekeyvaultClientId"
    trait.camel.apache.org/azure-key-vault.client-secret: "K8S_SECRET/CONFIGMAP"
spec:
  replicas: 1
  source:

Proposal

As I was talking previously through Zulip there is a similar solution for other traits specified in this PR (thanks to @oscerd and @squakez for this information) :

#4568

Open questions

No response

@jorgebg90 jorgebg90 added the kind/feature New feature or request label Sep 14, 2023
@oscerd oscerd self-assigned this Sep 14, 2023
@squakez
Copy link
Contributor

squakez commented Sep 14, 2023

If we're working on this, let's target this generically for any secret in vaults.

@oscerd
Copy link
Contributor

oscerd commented Sep 14, 2023

Sure thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traits kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants