Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41675: [Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41677

Merged
merged 31 commits into from
May 29, 2024

Conversation

sgilmore10
Copy link
Member

@sgilmore10 sgilmore10 commented May 15, 2024

Rationale for this change

In #41592, we added a CI job to build and test the MATLAB interface on macos-14, which is ARM-based. We currently only package the interface on macos-12, which is Intel-based.

We should add a crossbow job to package the MATLAB interface on macos-14 so that we package the interface for both Intel-based and ARM-based macoS.

What changes are included in this PR?

  1. Parameterized the macos job in the MATLAB crossbow workflow file to run on both macos-12 and macos-14.
  2. Added the bash script dev/tasks/matlab/rename_macos_dynamic_libraries.sh. This script is used to uniquify the shared library names generated for the Intel/AMD-based macOS and ARM-based macOS interface installations. This is required because the crossbow job generates one "monolithic" MLTBX file that contains all shared libraries for all platforms. See the comment at the beginning of dev/tasks/matlab/rename_macos_dynamic_libraries.sh for a more in-depth explanation.

Are these changes tested?

  1. Installed the MATLAB Arrow Interface on both Intel-based and ARM-based macOS machines using the MLTBX file generated by this crossbow job. All unit tests passed.

Are there any user-facing changes?

Users on ARM-based macOS machines will be able to install the MATLAB Arrow Interface via a "one-click" install
workflow using the MLTBX file.

@github-actions github-actions bot added the awaiting review Awaiting review label May 15, 2024
@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: 0a9adea

Submitted crossbow builds: ursacomputing/crossbow @ actions-2c74dc47d1

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: 4166464

Submitted crossbow builds: ursacomputing/crossbow @ actions-73015ffe49

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: daf8557

Submitted crossbow builds: ursacomputing/crossbow @ actions-75ef64fd55

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: a444c7d

Submitted crossbow builds: ursacomputing/crossbow @ actions-ee0e0dc048

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: 3e0d9a1

Submitted crossbow builds: ursacomputing/crossbow @ actions-f3e6a4f210

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: e1b3b9f

Submitted crossbow builds: ursacomputing/crossbow @ actions-e50cfc7cb8

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: 955c70b

Submitted crossbow builds: ursacomputing/crossbow @ actions-4f1fb0e2cd

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: 7fd016a

Submitted crossbow builds: ursacomputing/crossbow @ actions-774ecfa005

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: cf7b6e1

Submitted crossbow builds: ursacomputing/crossbow @ actions-4b09295f7a

Task Status
matlab GitHub Actions

@sgilmore10 sgilmore10 marked this pull request as ready for review May 28, 2024 18:42
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

dev/tasks/matlab/github.yml Outdated Show resolved Hide resolved
dev/tasks/matlab/github.yml Outdated Show resolved Hide resolved
dev/tasks/matlab/rename_macos_dynamic_libraries.sh Outdated Show resolved Hide resolved
dev/tasks/matlab/rename_macos_dynamic_libraries.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 29, 2024
sgilmore10 and others added 2 commits May 29, 2024 09:21
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: f0a048c

Submitted crossbow builds: ursacomputing/crossbow @ actions-aabbba2f3f

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: 7958cf1

Submitted crossbow builds: ursacomputing/crossbow @ actions-b1f520b25d

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: 1e339d7

Submitted crossbow builds: ursacomputing/crossbow @ actions-880a0245bd

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member Author

Re-ran the crossbow job with the new changes. Everything passed.

@sgilmore10 sgilmore10 merged commit 4a2df66 into apache:main May 29, 2024
6 checks passed
@sgilmore10 sgilmore10 deleted the GH-41675 branch May 29, 2024 14:30
@sgilmore10 sgilmore10 removed the awaiting merge Awaiting merge label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants