Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41675

Closed
sgilmore10 opened this issue May 15, 2024 · 1 comment
Closed

[Packaging][MATLAB] Add crossbow job to package MATLAB interface on macos-14 #41675

sgilmore10 opened this issue May 15, 2024 · 1 comment
Assignees
@sgilmore10
Labels
Component: MATLAB Component: Packaging Type: enhancement
Milestone
17.0.0

Comments

@sgilmore10
Copy link
Member

Describe the enhancement requested

In #41592, we added a CI job to build and test the MATLAB interface on macos-14, which is ARM-based. We currently only package the interface on macos-12, which is Intel-based.

We should add a crossbow job to package the MATLAB interface on macos-14 so that we package the interface for both Intel-based and ARM-based macoS.

Component(s)

MATLAB, Packaging
@sgilmore10 sgilmore10 self-assigned this May 15, 2024
@github-actions github-actions bot mentioned this issue May 15, 2024
Merged
sgilmore10 added a commit that referenced this issue May 29, 2024
@sgilmore10 @kou
GH-41675: [Packaging][MATLAB] Add crossbow job to package MATLAB inte…
4a2df66 
…rface on macos-14 (#41677)

### Rationale for this change

In #41592, we added a CI job to build and test the MATLAB interface on `macos-14`, which is ARM-based. We currently only package the interface on `macos-12`, which is Intel-based. 

We should add a crossbow job to package the MATLAB interface on `macos-14` so that we package the interface for both Intel-based and ARM-based macoS. 

### What changes are included in this PR?

1. Parameterized the `macos` job in the MATLAB crossbow workflow file to run on both `macos-12` and `macos-14`.
2. Added the bash script `dev/tasks/matlab/rename_macos_dynamic_libraries.sh`. This script is used to uniquify the shared library names generated for the Intel/AMD-based macOS and ARM-based macOS interface installations. This is required because the crossbow job generates one "monolithic" MLTBX file that contains all shared libraries for all platforms. See the [comment](https://github.com/apache/arrow/pull/41677/files#diff-99731016fc39dd96d2d239cf9cc132a8dacb9569c49bea4a64d69911b4dcc8c4R82) at the beginning of `dev/tasks/matlab/rename_macos_dynamic_libraries.sh` for a more in-depth explanation. 

### Are these changes tested?

1. Installed the MATLAB Arrow Interface on both Intel-based and ARM-based macOS machines using the MLTBX file generated by [this crossbow job](https://github.com/ursacomputing/crossbow/actions/runs/9274264286/job/25516244719). All unit tests passed.

### Are there any user-facing changes?

Users on ARM-based macOS machines will be able to install the MATLAB Arrow Interface via a "one-click" install 
workflow using the MLTBX file.

* GitHub Issue: #41675

Lead-authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Co-authored-by: Sarah Gilmore <74676073+sgilmore10@users.noreply.github.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sarah Gilmore <sgilmore@mathworks.com>
@sgilmore10
Copy link
Member Author

Issue resolved by pull request 41677
#41677

@sgilmore10 sgilmore10 added this to the 17.0.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgilmore10 sgilmore10

Labels
Component: MATLAB Component: Packaging Type: enhancement
Projects
Arrow MATLAB
Status: Done
Milestone
17.0.0
Development

No branches or pull requests
1 participant
@sgilmore10