feat: extend doc-build to be windows compatible #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Since it is now compatible with Windows, we should leverage it in windows dedicated actions!
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
SMoraisAnsys
commented
Apr 10, 2024
SMoraisAnsys
commented
Apr 10, 2024
SMoraisAnsys
commented
Apr 10, 2024
|
Workflow is working for pyedb (ansys/pyedb#267) |
jorgepiloto
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Just left some minor comments for improving the docs. Thanks for the big effort you put on this, @SMoraisAnsys.
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
RobPasMue
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says.
Closes #319
Note: Replaces #429 to trigger CICD.