Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong action version in doc-build #454

Merged
merged 1 commit into from Apr 15, 2024

Conversation

SMoraisAnsys
Copy link
Contributor

Seems like #453 got merged before I could change the version it was pointing to. It was left pointing to the development branch to let anyone test the action on their repo as it was performed in ansys/pyansys-geometry#1068.

I should have left a warning to notify of that, sorry for not thinking about it.

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner April 12, 2024 09:02
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Apr 12, 2024
@SMoraisAnsys SMoraisAnsys changed the title FIX: Wrong action version in doc-build fix: wrong action version in doc-build Apr 12, 2024
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault. Thanks, @SMoraisAnsys.

Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MaxJPRey
Copy link
Contributor

Seems like #453 got merged before I could change the version it was pointing to. It was left pointing to the development branch to let anyone test the action on their repo as it was performed in ansys/pyansys-geometry#1068.

I should have left a warning to notify of that, sorry for not thinking about it.

No problem @SMoraisAnsys

@MaxJPRey
Copy link
Contributor

My fault. Thanks, @SMoraisAnsys.

No problem @jorgepiloto

@jorgepiloto jorgepiloto enabled auto-merge (squash) April 15, 2024 07:44
@jorgepiloto jorgepiloto merged commit 9138d8e into main Apr 15, 2024
15 of 16 checks passed
@jorgepiloto jorgepiloto deleted the fix/doc-build-action-version branch April 15, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants