Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.0.2 #88

Merged
merged 4 commits into from
Jan 12, 2023
Merged

Version 4.0.2 #88

merged 4 commits into from
Jan 12, 2023

Conversation

holblin
Copy link

@holblin holblin commented Jan 11, 2023

Description

This PR fixes issues #71 and #77.

Related Issue

#71 : @import does not work if url contains ';'
#77 : Regression in selector parsing: Attribute selectors not parsed correctly

Motivation and Context

Some optimization of version 4 was a little bit too aggressive which lead to regressions.
Improve the parsing of CSS to allow the character ;

How Has This Been Tested?

Through unit-tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@holblin holblin merged commit 6836400 into main Jan 12, 2023
@holblin holblin deleted the version-4.0.2 branch January 12, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant