Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@import does not work if url contains ';' #71

Closed
steffanhalv opened this issue Nov 7, 2022 · 3 comments
Closed

@import does not work if url contains ';' #71

steffanhalv opened this issue Nov 7, 2022 · 3 comments

Comments

@steffanhalv
Copy link

Expected Behaviour

This should be parsed correctly

let demo = cssCompiler.parse(`
@import url('https://fonts.googleapis.com/css2?family=Zen+Kaku+Gothic+New:wght@300;400;500;700;900&display=swap');
.test {
  background: red;
  font-family: 'Zen Kaku Gothic New', sans-serif;
}
`)

console.log('demo', demo)

Actual Behaviour

`@import url('https://fonts.googleapis.com/css2?family=Zen+Kaku+Gothic+New:wght@300``

Becomes the first declaration and 400;500;700;900&display=swap')the second.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Run the code above

Platform and Version

4.0.1

Sample Code that illustrates the problem

Look ahead

Logs taken while reproducing problem

N/A

@holblin holblin mentioned this issue Jan 11, 2023
10 tasks
@holblin
Copy link

holblin commented Jan 11, 2023

Hi @steffanhalv , could you check if this PR fixes your problems?

@steffanhalv
Copy link
Author

Yes, thx it does :)

holblin added a commit that referenced this issue Jan 12, 2023
* Fix #77: Regression in selector parsing: Attribute selectors not parsed correctly

* Bump webpack-cli to 5.0.1

* Fix #71: @import does not work if url contains ';'

Co-authored-by: Jean-Philippe Zolesio <zolesio@adobe.com>
@holblin
Copy link

holblin commented Jan 12, 2023

The new version is published in npm 👍
Thanks for the report! It was much appreciated :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants