New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix Zstd breaking due to version change in runners #1353
Conversation
…rking. Defaulting to zstd without long as that is what is always happening currently.
976c8e8
to
853e85a
Compare
853e85a
to
0f91c9c
Compare
Checks are failing. Please fix the unit tests. |
8708d41
to
e6e2984
Compare
try { | ||
await exec.exec(`${app} --version`, [], { | ||
await exec.exec(`${app}`, additionalArgs, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @pdotl!
Just saw this while looking at the PR. '${app}'
seems a bit redundant. The first argument should be a string and app
is already one. Maybe you can fix that when you address the zstd --long
issue. It would be a bit much to open a separate PR for it 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @cdce8p will take this up in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to remove --long check entirely. --quiet would supress warnings but not clear how that would help in semver readable text
Found this in the documentation for
|
Summary
Currently zstd check is dependent on the text output of the
zstd --version
to includezstd command line interface
. This text changed to*** Zstandard CLI (64-bit) v1.5.4, by Yann Collet ***
breaking the check and@actions/cache
always falling back togzip
compression.Implementation
gzip
if the version output string is empty which should be the case if zstd is not installed.--quiet
flag tozstd
so moving on thezstd --version
should output machine readable version parsable via SemVer instead of text.--long
as that is what currently happens.Next Steps
Will have another PR that fixes use of
zstd
with--long
as intended. This release should unblockzstd
usage.Issues
Fixes #1341