Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners #1118

lvpx · 2023-02-20T19:52:10Z

Description

This PR adds changes to fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners. Please see this PR in actions/toolkit for changes.

Motivation and Context

Fixes #1110
Fixes #1114
Potentially fixes #1116

How Has This Been Tested?

Tested with all hosted runners using workflows and ensured all test cases pass on CI.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (add or update README or docs)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

kduret · 2023-02-21T08:21:33Z

I confirm this fixed my issue
good job @pdotl

DerTim1 · 2023-02-21T10:16:03Z

@pdotl Can you please tag that version and also move tag v3 to this release?

lvpx · 2023-02-21T10:33:50Z

@DerTim1 I have tagged the version and moved it to v3.

chetbox · 2023-02-21T11:05:41Z

I re-ran a job that was failing, which seems to have picked up a newer of action/cache@v3, but I am still having the same problem.

Download action repository 'actions/cache@v3' (SHA:95b455a0fba5a5e1770cc10ded51e5fe99a6737b)

Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set

I tried again with actions/cache@69d9d449aced6a2ede0bc19182fadc3a0a42d2b0 and it worked.

@pdotl it looks to me like the v3 tag needs to be moved to 69d9d449aced6a2ede0bc19182fadc3a0a42d2b0?

lvpx · 2023-02-21T11:35:11Z

@chetbox fixed! 👍

chetbox · 2023-02-21T13:19:23Z

Thanks @pdotl, looks good now. Much appreciated.

atsju · 2023-02-21T14:28:44Z

I had this problem first time today after the fix :
Download action repository 'actions/cache@v3' (SHA:69d9d449aced6a2ede0bc19182fadc3a0a42d2b0)
Cache not found for input keys: Windows-mingw810_64
https://github.com/atsju/DFTFringe/actions/runs/4233014638/jobs/7353437839
And the cache existed.
Are caches supposed to be invalidated automatically when the action is updated ?

vmarkovtsev · 2023-02-21T15:29:52Z

Our CI has started to fail after the new release. It looks like either some or all files are not restored from the cache now. Example. The same cache worked on a different runner: link.
We tried to drop all the caches. That didn't help.

cdce8p · 2023-02-21T15:43:14Z

Are caches supposed to be invalidated automatically when the action is updated ?

That is expected. You'll need to rebuild all caches with v3.2.6.
That's because now the action correctly looks for zstd caches if it is installed and only if not falls back to the glib defaults. Over the last few days the zstd version parsing was broken which caused only glib caches to be created.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/cache](https://togithub.com/actions/cache) | action | minor | `v3.2.4` -> `v3.3.0` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | patch | `v2.2.3` -> `v2.2.5` | | [trunk-io/trunk-action](https://togithub.com/trunk-io/trunk-action) | action | patch | `v1.0.6` -> `v1.0.7` | --- ### Release Notes <details> <summary>actions/cache</summary> ### [`v3.3.0`](https://togithub.com/actions/cache/releases/tag/v3.3.0) [Compare Source](https://togithub.com/actions/cache/compare/v3.2.6...v3.3.0) #### What's Changed - Bug: Permission is missing in cache delete example by [@kotokaze](https://togithub.com/kotokaze) in [https://github.com/actions/cache/pull/1123](https://togithub.com/actions/cache/pull/1123) - Add `lookup-only` option by [@cdce8p](https://togithub.com/cdce8p) in [https://github.com/actions/cache/pull/1041](https://togithub.com/actions/cache/pull/1041) #### New Contributors - [@kotokaze](https://togithub.com/kotokaze) made their first contribution in [https://github.com/actions/cache/pull/1123](https://togithub.com/actions/cache/pull/1123) **Full Changelog**: actions/cache@v3...v3.3.0 ### [`v3.2.6`](https://togithub.com/actions/cache/releases/tag/v3.2.6) [Compare Source](https://togithub.com/actions/cache/compare/v3.2.5...v3.2.6) ##### What's Changed - Updated branch in Force deletion of caches by [@t-dedah](https://togithub.com/t-dedah) in [https://github.com/actions/cache/pull/1108](https://togithub.com/actions/cache/pull/1108) - Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners by [@pdotl](https://togithub.com/pdotl) in [https://github.com/actions/cache/pull/1118](https://togithub.com/actions/cache/pull/1118) **Full Changelog**: actions/cache@v3...v3.2.6 ### [`v3.2.5`](https://togithub.com/actions/cache/releases/tag/v3.2.5) [Compare Source](https://togithub.com/actions/cache/compare/v3.2.4...v3.2.5) ##### What's Changed - Rewrite readmes by [@jsoref](https://togithub.com/jsoref) in [https://github.com/actions/cache/pull/1085](https://togithub.com/actions/cache/pull/1085) - Fixed typos and formatting in docs by [@kotewar](https://togithub.com/kotewar) in [https://github.com/actions/cache/pull/1076](https://togithub.com/actions/cache/pull/1076) - Fixing paths for OSes by [@kotewar](https://togithub.com/kotewar) in [https://github.com/actions/cache/pull/1101](https://togithub.com/actions/cache/pull/1101) - Release patch version update by [@Phantsure](https://togithub.com/Phantsure) in [https://github.com/actions/cache/pull/1105](https://togithub.com/actions/cache/pull/1105) ##### New Contributors - [@jsoref](https://togithub.com/jsoref) made their first contribution in [https://github.com/actions/cache/pull/1085](https://togithub.com/actions/cache/pull/1085) **Full Changelog**: actions/cache@v3...v3.2.5 </details> <details> <summary>github/codeql-action</summary> ### [`v2.2.5`](https://togithub.com/github/codeql-action/compare/v2.2.4...v2.2.5) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.2.4...v2.2.5) ### [`v2.2.4`](https://togithub.com/github/codeql-action/compare/v2.2.3...v2.2.4) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.2.3...v2.2.4) </details> <details> <summary>trunk-io/trunk-action</summary> ### [`v1.0.7`](https://togithub.com/trunk-io/trunk-action/releases/tag/v1.0.7) [Compare Source](https://togithub.com/trunk-io/trunk-action/compare/v1.0.6...v1.0.7) Introduce a caching-only mode, controlled via `check-mode: populate_cache_only`. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/trunk-io/plugins).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

JannikWo · 2024-07-17T08:43:23Z

dist/restore-only/index.js

        else {
-            return constants_1.CompressionMethod.Zstd;
+            return constants_1.CompressionMethod.ZstdWithoutLong;


Sorry for digging out this old PR, I got here following a bug.
But why are we not checking for the used zstd version here? Shouldn't be constants_1.CompressionMethod.Zstd still used when zstd is above v1.3.2?

lvpx added 4 commits February 20, 2023 19:40

Bump @actions/cache version

8f7fa5d

Update package-lock.json

7d4d6f7

Fix zstd breaking after new version release

b1db4b4

lvpx requested a review from a team as a code owner February 20, 2023 19:52

github-actions bot requested a review from pallavx February 20, 2023 19:52

github-actions bot assigned pallavx Feb 20, 2023

Fix license

8d3a1e0

bishal-pdMSFT approved these changes Feb 21, 2023

View reviewed changes

rohanKanojia mentioned this pull request Feb 21, 2023

E2E tests failing with Cache not found for input keys eclipse-jkube/jkube-integration-tests#243

Closed

lvpx merged commit 69d9d44 into main Feb 21, 2023

edmorley mentioned this pull request Feb 24, 2023

Use zstd by default whenever possible Swatinem/rust-cache#121

Closed

kevinmatthes mentioned this pull request Feb 26, 2023

[Merged by Bors] - Dependabot(deps): Bump actions/cache from 3.2.5 to 3.2.6 kevinmatthes/libstrmem#26

Closed

JannikWo reviewed Jul 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners #1118

Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners #1118

lvpx commented Feb 20, 2023

kduret commented Feb 21, 2023

DerTim1 commented Feb 21, 2023

lvpx commented Feb 21, 2023

chetbox commented Feb 21, 2023 •

edited

Loading

lvpx commented Feb 21, 2023

chetbox commented Feb 21, 2023

atsju commented Feb 21, 2023

vmarkovtsev commented Feb 21, 2023 •

edited

Loading

cdce8p commented Feb 21, 2023

JannikWo Jul 17, 2024

Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners #1118

Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners #1118

Conversation

lvpx commented Feb 20, 2023

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

kduret commented Feb 21, 2023

DerTim1 commented Feb 21, 2023

lvpx commented Feb 21, 2023

chetbox commented Feb 21, 2023 • edited Loading

lvpx commented Feb 21, 2023

chetbox commented Feb 21, 2023

atsju commented Feb 21, 2023

vmarkovtsev commented Feb 21, 2023 • edited Loading

cdce8p commented Feb 21, 2023

JannikWo Jul 17, 2024

Choose a reason for hiding this comment

chetbox commented Feb 21, 2023 •

edited

Loading

vmarkovtsev commented Feb 21, 2023 •

edited

Loading