Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy to install git on an Action Runner Image #3273

Merged
merged 1 commit into from May 15, 2024

Conversation

jww3
Copy link
Contributor

@jww3 jww3 commented May 3, 2024

The version of git (v2.34.1) associated with ubuntu:jammy is quite old at this point. Calling apt update out-of-the-box won't cause any newer version to be discovered.

This change allows users of the actions/runner container image to easily install more modern versions of git (e.g. v2.43.0) should they desire.

Note that we don't actually install git. We simply get the prerequisites out of the way.

Related Issues

@jww3
Copy link
Contributor Author

jww3 commented May 3, 2024

While we're at it, should we also perform these prerequisites to facilitate installation of the gh cli?

Comment on lines +42 to 44
RUN apt update -y \
&& apt install -y --no-install-recommends sudo lsb-release software-properties-common \
&& rm -rf /var/lib/apt/lists/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm combining these into a single line to aid readability. (One command per line).

The net change here is to install software-properties-common. (We still install sudo and lsb-release.)

software-properties-common is required for the new instruction on line 47, add-apt-repository

(We don't actually install `git`.  We simply get the prerequisites out of the way.)
@TingluoHuang TingluoHuang enabled auto-merge (squash) May 15, 2024 17:56
@TingluoHuang TingluoHuang merged commit 0f15173 into actions:main May 15, 2024
10 checks passed
@jww3 jww3 deleted the patch-1 branch May 15, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants