Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix input handling #357

Merged
merged 2 commits into from Apr 4, 2023
Merged

fix input handling #357

merged 2 commits into from Apr 4, 2023

Commits on Apr 4, 2023

  1. Clean and spruce up the integration tests a bit 

    - Use test-specific step ids
- Remove unused input parameters
- Provide clear output on what passed or failed, including
  a step summary for each passed test.
    @mjpieters
    mjpieters committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    806be26 View commit details
    Browse the repository at this point in the history

  2. Fix null handling, covered by integration tests 

    `core.getInput()` always returns a string, so testing for 'not null'
is always true. This then leads to previews set to an array with
a single empty string, breaking accept-header output.

Updated eslint rules should help avoid this issue in future, and new
integration tests verify that the github client configuration now
reflects the intended configuration options.
    @mjpieters
    mjpieters committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    8d9f8fc View commit details
    Browse the repository at this point in the history