Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix input handling #357

Merged
merged 2 commits into from Apr 4, 2023
Merged

fix input handling #357

merged 2 commits into from Apr 4, 2023

Conversation

mjpieters
Copy link
Contributor

@mjpieters mjpieters commented Mar 30, 2023 •
edited

This PR fixes how github-script handles the inputs given, which in turn
unbreaks how the Octokit request defaults are set.

I've included an extra ESLint rule to guard against the error in future, as
well as expanded the integration tests to cover action settings better.

  • Clean and spruce up the integration tests a bit
    • Use test-specific step ids
    • Remove unused input parameters
    • Provide clear output on what passed or failed, including a step summary for each passed test.
  • Fix null handling, covered by integration tests
    • core.getInput() always returns a string, so testing for 'not null' is always true. This then leads to previews set to an array with a single empty string, breaking accept-header output.
    • Updated eslint rules should help avoid this issue in future, and new integration tests verify that the github client configuration now reflects the intended configuration options.

Fixes #243

@mjpieters mjpieters requested a review from a team as a code owner March 30, 2023 13:58
@mjpieters
Copy link
Contributor Author

mjpieters commented Mar 30, 2023 •
edited

See https://github.com/actions/github-script/actions/runs/4611973839 for an example of what the integration test summaries look like.

@mjpieters
Clean and spruce up the integration tests a bit
806be26 
- Use test-specific step ids
- Remove unused input parameters
- Provide clear output on what passed or failed, including
  a step summary for each passed test.
joshmgross
joshmgross reviewed Apr 4, 2023
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
joshmgross
joshmgross approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion, but not a blocker. Thanks for adding all those integration tests!

@mjpieters
Fix null handling, covered by integration tests
8d9f8fc 
`core.getInput()` always returns a string, so testing for 'not null'
is always true. This then leads to previews set to an array with
a single empty string, breaking accept-header output.

Updated eslint rules should help avoid this issue in future, and new
integration tests verify that the github client configuration now
reflects the intended configuration options.
@joshmgross joshmgross merged commit f1ab577 into actions:main Apr 4, 2023
12 checks passed
@mjpieters mjpieters deleted the fix_input_handling branch April 5, 2023 07:54
renovate bot added a commit to JoshuaKGoldberg/create-typescript-app that referenced this pull request Apr 8, 2023
@renovate
chore(deps): update actions/github-script action to v6.4.1 (#365)
c4da3e5 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | patch | `v6.4.0` -> `v6.4.1` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

###
[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)

#### What's Changed

- Add
[@&#8203;octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),
to produce debug output for requests by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#358
- fix input handling by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#357
- Remove unused dependencies by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#356
- Default debug to current runner debug state by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#363

#### New Contributors

- [@&#8203;mjpieters](https://togithub.com/mjpieters) made their first
contribution in
[actions/github-script#358

**Full Changelog**:
actions/github-script@v6.4.0...v6.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/JoshuaKGoldberg/template-typescript-node-package).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNy4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzcuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to JoshuaKGoldberg/ts-api-utils that referenced this pull request Apr 8, 2023
@renovate
chore(deps): update actions/github-script action to v6.4.1 (#194)
c0b6820 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | patch | `v6.4.0` -> `v6.4.1` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

###
[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)

##### What's Changed

- Add
[@&#8203;octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),
to produce debug output for requests by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#358
- fix input handling by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#357
- Remove unused dependencies by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#356
- Default debug to current runner debug state by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#363

##### New Contributors

- [@&#8203;mjpieters](https://togithub.com/mjpieters) made their first
contribution in
[actions/github-script#358

**Full Changelog**:
actions/github-script@v6.4.0...v6.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/JoshuaKGoldberg/ts-api-utils).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNy4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzcuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
thedoublejay pushed a commit to levaintech/sticky that referenced this pull request Apr 10, 2023
@renovate
bump(deps): update actions/github-script action to v6.4.1 (#129)
a8629da 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | minor | `v6.3.3` -> `v6.4.1` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

###
[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)

#### What's Changed

- Add
[@&#8203;octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),
to produce debug output for requests by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#358
- fix input handling by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#357
- Remove unused dependencies by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#356
- Default debug to current runner debug state by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#363

#### New Contributors

- [@&#8203;mjpieters](https://togithub.com/mjpieters) made their first
contribution in
[actions/github-script#358

**Full Changelog**:
actions/github-script@v6.4.0...v6.4.1

###
[`v6.4.0`](https://togithub.com/actions/github-script/releases/tag/v6.4.0)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.3.3...v6.4.0)

##### What's Changed

- Bump json5 from 2.1.3 to 2.2.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/github-script#319
- Bump minimatch from 3.0.4 to 3.1.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/github-script#320
- Add node-fetch by
[@&#8203;danmichaelo](https://togithub.com/danmichaelo) in
[actions/github-script#321

##### New Contributors

- [@&#8203;jongwooo](https://togithub.com/jongwooo) made their first
contribution in
[actions/github-script#313
- [@&#8203;austinvazquez](https://togithub.com/austinvazquez) made their
first contribution in
[actions/github-script#306
- [@&#8203;danmichaelo](https://togithub.com/danmichaelo) made their
first contribution in
[actions/github-script#321

**Full Changelog**:
actions/github-script@v6.3.3...v6.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/sticky).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh pushed a commit to BirthdayResearch/jellyfishsdk that referenced this pull request Apr 10, 2023
@renovate
bump(deps): update actions/github-script action to v6.4.1 (#2090)
7c5945c 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | patch | `v6.4.0` -> `v6.4.1` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

###
[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)

##### What's Changed

- Add
[@&#8203;octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),
to produce debug output for requests by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#358
- fix input handling by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#357
- Remove unused dependencies by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#356
- Default debug to current runner debug state by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#363

##### New Contributors

- [@&#8203;mjpieters](https://togithub.com/mjpieters) made their first
contribution in
[actions/github-script#358

**Full Changelog**:
actions/github-script@v6.4.0...v6.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNy4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzcuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kayman-mk pushed a commit to Hapag-Lloyd/Repository-Templates that referenced this pull request Nov 19, 2023
@renovate
chore(deps): update actions/github-script action to v6.4.1 (#42)
e478e82 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | patch | `v6.4.0` -> `v6.4.1` |

---

### Release Notes

<details>
<summary>actions/github-script (actions/github-script)</summary>

###
[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)

#### What's Changed

- Add
[@&#8203;octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),
to produce debug output for requests by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#358
- fix input handling by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#357
- Remove unused dependencies by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#356
- Default debug to current runner debug state by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#363

#### New Contributors

- [@&#8203;mjpieters](https://togithub.com/mjpieters) made their first
contribution in
[actions/github-script#358

**Full Changelog**:
actions/github-script@v6.4.0...v6.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Hapag-Lloyd/Repository-Templates).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kayman-mk pushed a commit to Hapag-Lloyd/Renovate-Global-Configuration that referenced this pull request Nov 19, 2023
@renovate
chore(deps): update actions/github-script action to v7 (#48)
217f710 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | major | `v6.4.0` -> `v7.0.1` |

---

### Release Notes

<details>
<summary>actions/github-script (actions/github-script)</summary>

###
[`v7.0.1`](https://togithub.com/actions/github-script/releases/tag/v7.0.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v7.0.0...v7.0.1)

##### What's Changed

- Avoid setting `baseUrl` to undefined when input is not provided by
[@&#8203;joshmgross](https://togithub.com/joshmgross) in
[actions/github-script#439

**Full Changelog**:
actions/github-script@v7.0.0...v7.0.1

###
[`v7.0.0`](https://togithub.com/actions/github-script/releases/tag/v7.0.0)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.1...v7.0.0)

##### What's Changed

- Add base-url option by
[@&#8203;robandpdx](https://togithub.com/robandpdx) in
[actions/github-script#429
- Expose async-function argument type by
[@&#8203;viktorlott](https://togithub.com/viktorlott) in
[actions/github-script#402,
see for details
https://github.com/actions/github-script#use-scripts-with-jsdoc-support
- Update dependencies and use Node 20 by
[@&#8203;joshmgross](https://togithub.com/joshmgross) in
[actions/github-script#425

##### New Contributors

- [@&#8203;navarroaxel](https://togithub.com/navarroaxel) made their
first contribution in
[actions/github-script#285
- [@&#8203;robandpdx](https://togithub.com/robandpdx) made their first
contribution in
[actions/github-script#429
- [@&#8203;viktorlott](https://togithub.com/viktorlott) made their first
contribution in
[actions/github-script#402

**Full Changelog**:
actions/github-script@v6.4.1...v7.0.0

###
[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)

#### What's Changed

- Add
[@&#8203;octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),
to produce debug output for requests by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#358
- fix input handling by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#357
- Remove unused dependencies by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#356
- Default debug to current runner debug state by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#363

#### New Contributors

- [@&#8203;mjpieters](https://togithub.com/mjpieters) made their first
contribution in
[actions/github-script#358

**Full Changelog**:
actions/github-script@v6.4.0...v6.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Hapag-Lloyd/Renovate-Global-Configuration).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kayman-mk pushed a commit to Hapag-Lloyd/terraform-aws-bastion-host-ssm that referenced this pull request Nov 23, 2023
@renovate
chore(deps): update actions/github-script action to v6.4.1 (#175)
bd26edb 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | patch | `v6.4.0` -> `v6.4.1` |

---

### Release Notes

<details>
<summary>actions/github-script (actions/github-script)</summary>

###
[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)

#### What's Changed

- Add
[@&#8203;octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),
to produce debug output for requests by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#358
- fix input handling by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#357
- Remove unused dependencies by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#356
- Default debug to current runner debug state by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#363

#### New Contributors

- [@&#8203;mjpieters](https://togithub.com/mjpieters) made their first
contribution in
[actions/github-script#358

**Full Changelog**:
actions/github-script@v6.4.0...v6.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Hapag-Lloyd/terraform-aws-bastion-host-ssm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to Hapag-Lloyd/dist-comm-vis that referenced this pull request Nov 23, 2023
@renovate
chore(deps): update actions/github-script action to v6.4.1 (#142)
0cd4b9d 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | patch | `v6.4.0` -> `v6.4.1` |

---

### Release Notes

<details>
<summary>actions/github-script (actions/github-script)</summary>

###
[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)

#### What's Changed

- Add
[@&#8203;octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),
to produce debug output for requests by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#358
- fix input handling by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#357
- Remove unused dependencies by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#356
- Default debug to current runner debug state by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#363

#### New Contributors

- [@&#8203;mjpieters](https://togithub.com/mjpieters) made their first
contribution in
[actions/github-script#358

**Full Changelog**:
actions/github-script@v6.4.0...v6.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Hapag-Lloyd/dist-comm-vis).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 9, 2023
sagemathgh-36739: ⬆️ Bump actions/github-script from 6.4.0 to 7.0.1
2af5981 
    
Bumps [actions/github-script](https://github.com/actions/github-script)
from 6.4.0 to 7.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/github-
script/releases">actions/github-script's releases</a>.</em></p>
<blockquote>
<h2>v7.0.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Avoid setting <code>baseUrl</code> to undefined when input is not
provided by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/github-
script/pull/439">actions/github-script#439</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-
script/compare/v7.0.0...v7.0.1">https://github.com/actions/github-
script/compare/v7.0.0...v7.0.1</a></p>
<h2>v7.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add base-url option by <a
href="https://github.com/robandpdx"><code>@​robandpdx</code></a> in <a
href="https://redirect.github.com/actions/github-
script/pull/429">actions/github-script#429</a></li>
<li>Expose async-function argument type by <a
href="https://github.com/viktorlott"><code>@​viktorlott</code></a> in <a
href="https://redirect.github.com/actions/github-
script/pull/402">actions/github-script#402</a>, see for details <a
href="https://github.com/actions/github-script#use-scripts-with-jsdoc-
support">https://github.com/actions/github-script#use-scripts-with-
jsdoc-support</a></li>
<li>Update dependencies and use Node 20 by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/github-
script/pull/425">actions/github-script#425</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/navarroaxel"><code>@​navarroaxel</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-
script/pull/285">actions/github-script#285</a></li>
<li><a href="https://github.com/robandpdx"><code>@​robandpdx</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-
script/pull/429">actions/github-script#429</a></li>
<li><a
href="https://github.com/viktorlott"><code>@​viktorlott</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/github-
script/pull/402">actions/github-script#402</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-
script/compare/v6.4.1...v7.0.0">https://github.com/actions/github-
script/compare/v6.4.1...v7.0.0</a></p>
<h2>v6.4.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Add <code>@​octokit/plugin-request-log</code>, to produce debug
output for requests by <a
href="https://github.com/mjpieters"><code>@​mjpieters</code></a> in <a
href="https://redirect.github.com/actions/github-
script/pull/358">actions/github-script#358</a></li>
<li>fix input handling by <a
href="https://github.com/mjpieters"><code>@​mjpieters</code></a> in <a
href="https://redirect.github.com/actions/github-
script/pull/357">actions/github-script#357</a></li>
<li>Remove unused dependencies by <a
href="https://github.com/mjpieters"><code>@​mjpieters</code></a> in <a
href="https://redirect.github.com/actions/github-
script/pull/356">actions/github-script#356</a></li>
<li>Default debug to current runner debug state by <a
href="https://github.com/mjpieters"><code>@​mjpieters</code></a> in <a
href="https://redirect.github.com/actions/github-
script/pull/363">actions/github-script#363</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/mjpieters"><code>@​mjpieters</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-
script/pull/358">actions/github-script#358</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-
script/compare/v6.4.0...v6.4.1">https://github.com/actions/github-
script/compare/v6.4.0...v6.4.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="actions/github-script@60a0d83039c
74a4aee543508d2ffcb1c3799cdea"><code>60a0d83</code></a> Merge pull
request <a href="https://redirect.github.com/actions/github-
script/issues/440">sagemath#440</a> from actions/joshmgross/v7.0.1</li>
<li><a href="actions/github-script@b7fb2001b41
0c9390cbe9e2c7d5cab7eefb7b29c"><code>b7fb200</code></a> Update version
to 7.0.1</li>
<li><a href="actions/github-script@12e22ed06b6
cf302663f90a925045516e24c8bad"><code>12e22ed</code></a> Merge pull
request <a href="https://redirect.github.com/actions/github-
script/issues/439">sagemath#439</a> from actions/joshmgross/avoid-setting-base-
url</li>
<li><a href="actions/github-script@d319f8f5b55
ea40916b869b2ca9ae2f059c60abf"><code>d319f8f</code></a> Avoid setting
<code>baseUrl</code> to undefined when input is not provided</li>
<li><a href="actions/github-script@e69ef5462fd
455e02edcaf4dd7708eda96b9eda0"><code>e69ef54</code></a> Merge pull
request <a href="https://redirect.github.com/actions/github-
script/issues/425">sagemath#425</a> from actions/joshmgross/node-20</li>
<li><a href="actions/github-script@ee0914b839b
704083a749f8c77a73a9270674a32"><code>ee0914b</code></a> Update
licenses</li>
<li><a href="actions/github-script@d6fc56f33b0
17d55917d045da1a94efa2120f039"><code>d6fc56f</code></a> Use
<code>@types/node</code> for Node 20</li>
<li><a href="actions/github-script@384d6cf5814
52587d1e31f553c97ab165427124a"><code>384d6cf</code></a> Fix quotations
in tests</li>
<li><a href="actions/github-script@84724927e3e
992f17768c17f57a47a85ea2a5160"><code>8472492</code></a> Only validate
GraphQL <code>previews</code></li>
<li><a href="actions/github-script@84903f51828
821af5d03d3884c6ba699a2d44d6e"><code>84903f5</code></a> Remove
<code>node-fetch</code> from type</li>
<li>Additional commits viewable in <a
href="https://github.com/actions/github-
script/compare/v6.4.0...v7.0.1">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-
badges.githubapp.com/badges/compatibility_score?dependency-
name=actions/github-script&package-manager=github_actions&previous-
version=6.4.0&new-
version=7.0.1)](https://docs.github.com/en/github/managing-security-
vulnerabilities/about-dependabot-security-updates#about-compatibility-
scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
    
URL: sagemath#36739
Reported by: dependabot[bot]
Reviewer(s): Kwankyu Lee
@psobolewskiPhD psobolewskiPhD mentioned this pull request Mar 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmgross joshmgross joshmgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting mediaType doesn't work
2 participants
@mjpieters @joshmgross