Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying separate kube-rbac-proxy resource requirements #3333

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+7 −5
Open

Allow specifying separate kube-rbac-proxy resource requirements #3333

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1b86761
Update values.yaml
chotiwat Mar 8, 2024
ec207ed
Update README.md
chotiwat Mar 8, 2024
9a3fae0
Update README.md
chotiwat Mar 8, 2024
1bcb1a0
Update deployment.yaml
chotiwat Mar 8, 2024
d3ca4c6
Update actionsmetrics.deployment.yaml
chotiwat Mar 8, 2024
42a29a8
Update values.yaml
chotiwat Mar 8, 2024
1fae66e
Update README.md
chotiwat Mar 8, 2024
d195b73
Merge branch 'master' into chart-arc-proxy-resources
chotiwat Mar 21, 2024
5ab9442
Merge branch 'master' into chart-arc-proxy-resources
chotiwat Mar 26, 2024
ec513fc
Merge branch 'master' into chart-arc-proxy-resources
chotiwat Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/actions-runner-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ All additional docs are kept in the `docs/` folder, this README is solely for do
| `actionsMetrics.serviceMonitor.timeout` | Configure the timeout the timeout of Prometheus scrapping. | 30s |
| `actionsMetrics.serviceAnnotations` | Set annotations for the provisioned actions metrics service resource | |
| `actionsMetrics.port` | Set port of actions metrics service | 8443 |
| `actionsMetrics.proxy.enabled` | Deploy kube-rbac-proxy container in controller pod | true |
| `actionsMetrics.proxy.enabled` | Deploy kube-rbac-proxy container in the actions-metrics-server pod | true |
| `actionsMetrics.proxy.image.repository` | The "repository/image" of the kube-proxy container | quay.io/brancz/kube-rbac-proxy |
| `actionsMetrics.proxy.image.tag` | The tag of the kube-proxy image to use when pulling the container | v0.13.1 |
| `actionsMetrics.proxy.resources` | Set the kube-rbac-proxy container resources | |
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add metrics.proxy.resources to the table because none of the metrics.* values are here. Let me know if I should add them.

| `actionsMetrics.serviceMonitorLabels` | Set labels to apply to ServiceMonitor resources | |
2 changes: 1 addition & 1 deletion charts/actions-runner-controller/templates/actionsmetrics.deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ spec:
- containerPort: {{ .Values.actionsMetrics.port }}
name: metrics-port
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- toYaml .Values.actionsMetrics.proxy.resources | nindent 12 }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/actions-runner-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ spec:
- containerPort: {{ .Values.metrics.port }}
name: metrics-port
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- toYaml .Values.metrics.proxy.resources | nindent 12 }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
{{- end }}
Expand Down
5 changes: 3 additions & 2 deletions charts/actions-runner-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,9 @@ metrics:
image:
repository: quay.io/brancz/kube-rbac-proxy
tag: v0.13.1
resources: {}

resources:
{}
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
Expand Down Expand Up @@ -323,6 +323,7 @@ actionsMetrics:
image:
repository: quay.io/brancz/kube-rbac-proxy
tag: v0.13.1
resources: {}
# specify additional environment variables for the webhook server pod.
# It's possible to specify either key vale pairs e.g.:
# my_env_var: "some value"
Expand Down