Allow specifying separate kube-rbac-proxy resource requirements #3333
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chotiwat
requested review from
mumoshu,
toast-gear,
nikola-jokic and
a team
as code owners
chotiwat
commented
Mar 8, 2024
| | `actionsMetrics.proxy.image.repository` | The "repository/image" of the kube-proxy container | quay.io/brancz/kube-rbac-proxy | | ||
| | `actionsMetrics.proxy.image.tag` | The tag of the kube-proxy image to use when pulling the container | v0.13.1 | | ||
| | `actionsMetrics.proxy.resources` | Set the kube-rbac-proxy container resources | | |
There was a problem hiding this comment.
I didn't add metrics.proxy.resources to the table because none of the metrics.* values are here. Let me know if I should add them.
|
Hi @rentziass, could you take a look a this PR when you have a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actions-runner-controller Helm chart currently reuses the resource requirements of the manager container. This PR adds separate resource requirements for to the kube-rbac-proxy containers.