Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 16 #915

Merged
merged 12 commits into from Aug 24, 2023
Merged

Update to Angular 16 #915

merged 12 commits into from Aug 24, 2023

Conversation

VadimDez
Copy link
Owner

No description provided.

@VadimDez VadimDez mentioned this pull request Aug 21, 2022
@VadimDez VadimDez added this to the 10.0.0 milestone Sep 11, 2022
@knalepa
Copy link

knalepa commented Nov 9, 2022

Hi @VadimDez, are you going to merge it soon? Thank you

@stale
Copy link

stale bot commented Jan 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2023
@VadimDez VadimDez removed the stale label Jan 19, 2023
@stale
Copy link

stale bot commented May 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 19, 2023
@VadimDez VadimDez removed the stale label May 22, 2023
@SoyDiego
Copy link

Hi @VadimDez, will you update to Angular 16?
Thanks

@ChristopherVR
Copy link

Hi @VadimDez ,

Any change to update to Angular 16?

@acosme
Copy link

acosme commented Aug 18, 2023

Hi @VadimDez,

will this commit go to master?

@VadimDez VadimDez changed the title Update to Angular 14 Update to Angular 16 Aug 24, 2023
@VadimDez VadimDez merged commit e0e5840 into master Aug 24, 2023
2 checks passed
@VadimDez VadimDez deleted the feature/ng-14 branch August 24, 2023 21:43
@naviln
Copy link

naviln commented Aug 28, 2023

Hi @VadimDez,

Thanks for putting this upgrade out. I tried it out on my Angular 15 project, but getting the below error. Any tips/ideas?

image

Error: node_modules/ng2-pdf-viewer/src/app/pdf-viewer/pdf-viewer.component.d.ts:95:18 - error TS2707: Generic type 'ɵɵComponentDeclaration' requires between 7 and 9 type arguments.

95     static ɵcmp: i0.ɵɵComponentDeclaration<PdfViewerComponent, "pdf-viewer", never, { "src": { "alias": "src"; "required": false; }; "cMapsUrl": { "alias": "c-maps-url"; "required": false; }; "page": { "alias": "page"; "required": false; }; "renderText": { "alias": "render-text"; "required": false; }; "renderTextMode": { "alias": "render-text-mode"; "required": false; }; "originalSize": { "alias": "original-size"; "required": false; }; "showAll": { "alias": "show-all"; "required": false; }; "stickToPage": { "alias": "stick-to-page"; "required": false; }; "zoom": { "alias": "zoom"; "required": false; }; "zoomScale": { "alias": "zoom-scale"; "required": false; }; "rotation": { "alias": "rotation"; "required": false; }; "externalLinkTarget": { "alias": "external-link-target"; "required": false; }; "autoresize": { "alias": "autoresize"; "required": false; }; "fitToPage": { "alias": "fit-to-page"; "required": false; }; "showBorders": { "alias": "show-borders"; "required": false; }; }, { "afterLoadComplete": "after-load-complete"; "pageRendered": "page-rendered"; "pageInitialized": "pages-initialized"; "textLayerRendered": "text-layer-rendered"; "onError": "error"; "onProgress": "on-progress"; "pageChange": "pageChange"; }, never, never, false, never, false>;

EDIT: Never mind, I tried upgrading to Angular 16, and it works now. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants