Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 14 #917

Closed
wants to merge 7 commits into from
Closed

Update to Angular 14 #917

wants to merge 7 commits into from

Conversation

ODAncona
Copy link

I tried:

npm run test

and everything seemed to work.

@VadimDez
Copy link
Owner

I don't know if you've seen that there was already #915 for this

@ODAncona
Copy link
Author

Indeed, but I'm not sure how to proceed. I just forked the repo, updated to 14 and opened a PR because I saw your was failing. What should I've done?

@VadimDez
Copy link
Owner

First of all thanks for you contribution, I really appreciate it!
I wouldn't recommend tackle the same issue/feature in parallel.
I did assign #914 to myself and was still working on #915 branch (was trying to fix the SSR issue) that's why i didn't commit latest changes 😅

@ODAncona
Copy link
Author

Should we merge this pull request and open a new one for the ssr problem?

@stale
Copy link

stale bot commented Nov 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 12, 2022
@stale stale bot closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants