Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new parsing util functions for Exprs #235

Merged
merged 1 commit into from May 25, 2023
Merged

Add new parsing util functions for Exprs #235

merged 1 commit into from May 25, 2023

Conversation

TedDriggs
Copy link
Owner

This contributes to #229 by allowing crate users to more concisely choose the desired parsing behavior.

@TedDriggs
Copy link
Owner Author

@milesj pointed out here that these functions are not generic over wrapper types such as Option, which is unfortunate.

@TedDriggs
Copy link
Owner Author

It looks like these can be combined with the map field, so this works:

#[darling(with = "darling::util::parse_expr::preserve_str_literal", map = "Some")]

@TedDriggs TedDriggs mentioned this pull request May 22, 2023
Merged
@TedDriggs TedDriggs mentioned this pull request May 25, 2023
Closed
@TedDriggs TedDriggs merged commit 6d6f6e0 into master May 25, 2023
24 checks passed
@TedDriggs TedDriggs deleted the expr-parsing branch May 25, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@TedDriggs