new: Remove default_str and default_fn.
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedDriggs
reviewed
May 22, 2023
crates/macros/src/config/setting.rs
Outdated
| use syn::{Expr, ExprPath, Field, Type}; | ||
| use syn::{Expr, ExprPath, Field, Meta, Type}; | ||
|
|
||
| pub fn preserve_str_literal(meta: &Meta) -> darling::Result<Option<Expr>> { |
There was a problem hiding this comment.
The plan is to make this function (without the Option in the return type) available as part of the darling crate; see TedDriggs/darling#235 for that.
You can achieve the desired result here by adding map = "Some" to the attribute that is consuming this function (see comment suggestion below)
crates/macros/src/config/setting.rs
Outdated
|
|
||
| // #[setting()] | ||
| #[derive(FromAttributes, Default)] | ||
| #[darling(default, attributes(setting))] | ||
| pub struct SettingArgs { | ||
| #[darling(with = "preserve_str_literal")] |
There was a problem hiding this comment.
Suggested change
| #[darling(with = "preserve_str_literal")] | |
| #[darling(with = "preserve_str_literal", map = "Some")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now just use
default.TedDriggs/darling#229 (comment)