SONARPY-1826 Enable flow sensitive type inference for function types #1796
Conversation
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1826
branch
13 times, most recently
from
dd172c5
to
56fbaa2
Compare
guillaume-dequenne-sonarsource
requested a review
from maksim-grebeniuk-sonarsource
| public abstract class Propagation { | ||
|
|
||
| final Set<SymbolV2> variableDependencies = new HashSet<>(); | ||
| final Set<Propagation> dependents = new HashSet<>(); |
There was a problem hiding this comment.
initialize in the constructor?
| lhsSymbol.usages().stream() | ||
| .filter(u -> !SymbolV2Utils.isFunctionOrClassDeclaration(u)) | ||
| .map(UsageV2::tree) | ||
| .filter(NameImpl.class::isInstance) | ||
| .map(NameImpl.class::cast) | ||
| .forEach(n -> n.typeV2(rhsType)); |
There was a problem hiding this comment.
this part is the same as usages stream below, so maybe it makes sense to extend this common part?
| return lhsName.symbolV2().usages() | ||
| .stream() | ||
| .filter(u -> !SymbolV2Utils.isFunctionOrClassDeclaration(u)) | ||
| .map(UsageV2::tree) |
There was a problem hiding this comment.
maybe we can simply move this part to SymbolV2Utils:
public static Stream<Tree> getSymbolNonDeclarationUsageTrees(SymbolV2 symbol) {
return symbol.usages()
.stream()
.filter(u -> !SymbolV2Utils.isFunctionOrClassDeclaration(u))
.map(UsageV2::tree)
}There was a problem hiding this comment.
Good point! I extracted this into a dedicated method.
However, I kept it in Propagation, as I want the filtering out of definitions to be super explicit (I think it only makes sense in this specific case). I added a comment to clarify this in the now mutualized method.
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1825
branch
from
b7005eb
to
aeec2cd
Compare
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1826
branch
from
56fbaa2
to
68ead15
Compare
guillaume-dequenne-sonarsource
changed the title
|
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1826
branch
from
7f31bba
to
6b08403
Compare
guillaume-dequenne-sonarsource
merged commit 4920279
into
MMF-3796
No description provided.