SONARPY-1830 Prevent single-assigned module scope types from being pr…

…opagated to nested functions
SonarSource · May 14, 2024 · 6b08403 · 6b08403
1 parent 66d496f
commit 6b08403
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/python-checks/src/test/resources/checks/nonCallableCalled.py b/python-checks/src/test/resources/checks/nonCallableCalled.py
@@ -217,7 +217,7 @@ def calling_global_func():
 
 def using_nonlocal_var():
     nonlocal some_nonlocal_var
-    some_nonlocal_var()  # Noncompliant
+    some_nonlocal_var()  # OK
 
 
 def reassigned_function():

diff --git a/...rontend/src/main/java/org/sonar/python/semantic/v2/types/TrivialTypeInferenceVisitor.java b/...rontend/src/main/java/org/sonar/python/semantic/v2/types/TrivialTypeInferenceVisitor.java
@@ -364,6 +364,8 @@ public void visitName(Name name) {
       .filter(Expression.class::isInstance)
       .map(Expression.class::cast)
       .map(Expression::typeV2)
+      // FIXME: classes and functions should be propagated like other types
+      .filter(t -> (t instanceof ClassType) || (t instanceof FunctionType))
       .ifPresent(type -> setTypeToName(name, type));
   }