SONARPY-1815 Enable AST-based type inference for functions/module containing try/catch blocks #1792
Conversation
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1815
branch
2 times, most recently
from
e60a8be
to
7c38c22
Compare
| workList.push(expression); | ||
| while (!workList.isEmpty()) { | ||
| Expression e = workList.pop(); | ||
| if (e.is(Tree.Kind.NAME)) { |
There was a problem hiding this comment.
it is possible to do type check and type cast in single operation here:
if (e instanceof Name name) {
...
}|
|
||
| public record Assignment(SymbolV2 lhsSymbol, Name lhsName, Expression rhs) { | ||
| public class Assignment { |
There was a problem hiding this comment.
do we really need to have it as a class instead of a record?
There was a problem hiding this comment.
I don't have a strong opinion on what it should be, but if you don't mind, I'd rather keep this as it is here, since SONARPY-1826 refactors this again. Please have a look at that PR and I'm happy to further refactor it there into a record if that still makes sense (I didn't consider this tbh).
| final SymbolV2 lhsSymbol; | ||
| Name lhsName; | ||
| Expression rhs; | ||
| Set<SymbolV2> variableDependencies = new HashSet<>(); |
There was a problem hiding this comment.
I'd prefer to have a single place to initialize everything. If you have a constructor - may be it makes sense to initialize these fields there as well
There was a problem hiding this comment.
If you don't mind I'll address this as part of SONARPY-1826.
| void computeDependencies(Expression expression, Set<SymbolV2> trackedVars) { | ||
| Deque<Expression> workList = new ArrayDeque<>(); | ||
| workList.push(expression); | ||
| while (!workList.isEmpty()) { |
There was a problem hiding this comment.
Add a comment here to rework this part later. Add tests showing type tracking of collection item types
There was a problem hiding this comment.
I didn't add the comment, as I think we already have some tickets that relate to this anyway. However, I added a test that shows that collection item types actually work (for a trivial case).
| Set<Assignment> workSet = new HashSet<>(propagations); | ||
| while (!workSet.isEmpty()) { | ||
| Iterator<Assignment> iterator = workSet.iterator(); | ||
| Assignment propagation = iterator.next(); |
There was a problem hiding this comment.
rename to assignment and propagations parameter as well
There was a problem hiding this comment.
This will be updated in SONARPY-1826 (introducing Propagation class again).
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1815
branch
from
7c38c22
to
d48bdfa
Compare
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1818
branch
from
27fde47
to
245a7f4
Compare
|
…taining try/catch blocks
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1815
branch
from
ffc227a
to
e95d4d2
Compare
guillaume-dequenne-sonarsource
merged commit 081dc4a
into
MMF-3796
…taining try/catch blocks (#1792)
No description provided.