Basic implementation of ClassType and FunctionType toString

SonarSource · May 13, 2024 · 245a7f4 · 245a7f4
1 parent 14289c7
commit 245a7f4
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/python-frontend/src/main/java/org/sonar/python/types/v2/ClassType.java b/python-frontend/src/main/java/org/sonar/python/types/v2/ClassType.java
@@ -184,4 +184,9 @@ public boolean equals(Object o) {
   public int hashCode() {
     return Objects.hash(name, members, attributes, superClasses);
   }
+
+  @Override
+  public String toString() {
+    return "ClassType[%s]".formatted(name);
+  }
 }
diff --git a/python-frontend/src/main/java/org/sonar/python/types/v2/FunctionType.java b/python-frontend/src/main/java/org/sonar/python/types/v2/FunctionType.java
@@ -70,4 +70,10 @@ public Optional<LocationInFile> definitionLocation() {
   public int hashCode() {
     return Objects.hash(name, attributes, parameters, returnType, isAsynchronous, hasDecorators, isInstanceMethod, hasVariadicParameter);
   }
+
+
+  @Override
+  public String toString() {
+    return "FunctionType[%s]".formatted(name);
+  }
 }
diff --git a/python-frontend/src/test/java/org/sonar/python/types/v2/ClassTypeTest.java b/python-frontend/src/test/java/org/sonar/python/types/v2/ClassTypeTest.java
@@ -57,6 +57,7 @@ void no_parents() {
     assertThat(classType.hasUnresolvedHierarchy()).isFalse();
     // TODO: not correct
     assertThat(classType.key()).isEqualTo("C[]");
+    assertThat(classType).hasToString("ClassType[C]");
 
     assertThat(classType.hasMember("__call__")).isEqualTo(TriBool.TRUE);
     assertThat(classType.hasMember("unknown")).isEqualTo(TriBool.UNKNOWN);

diff --git a/python-frontend/src/test/java/org/sonar/python/types/v2/FunctionTypeTest.java b/python-frontend/src/test/java/org/sonar/python/types/v2/FunctionTypeTest.java
@@ -46,6 +46,7 @@ void arity() {
     assertThat(functionType.isAsynchronous()).isFalse();
     assertThat(functionType.parameters()).isEmpty();
     assertThat(functionType.displayName()).contains("Callable");
+    assertThat(functionType).hasToString("FunctionType[fn]");
     assertThat(functionType.unwrappedType()).isEqualTo(functionType);
     assertThat(functionType.instanceDisplayName()).isEmpty();
     String fileId = SymbolUtils.pathOf(pythonFile).toString();