Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable razor UTs in-memory compilation (#9190)" #9214

Merged
merged 1 commit into from Apr 26, 2024

Conversation

Tim-Pohlmann
Copy link
Contributor

This reverts commit 97af801.

The PR was merged too early. It makes all Razor UTs meaningless. Razor files are not actually analyzed and all tests are green all the time.

@github-actions github-actions bot added this to In progress in Best Kanban Apr 26, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Apr 26, 2024
Copy link
Contributor

@CristianAmbrosini CristianAmbrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Apr 26, 2024
@Tim-Pohlmann Tim-Pohlmann enabled auto-merge (squash) April 26, 2024 13:23
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Failed Quality Gate failed for 'SonarAnalyzer for .NET'

Failed conditions
87.3% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 735b0a1 into master Apr 26, 2024
29 of 30 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Apr 26, 2024
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Tim/RevertRazorUTs branch April 26, 2024 13:59
@Tim-Pohlmann Tim-Pohlmann linked an issue Apr 30, 2024 that may be closed by this pull request
3 tasks
@Tim-Pohlmann Tim-Pohlmann restored the Tim/RevertRazorUTs branch May 2, 2024 08:07
@Tim-Pohlmann Tim-Pohlmann deleted the Tim/RevertRazorUTs branch May 2, 2024 08:08
@Tim-Pohlmann Tim-Pohlmann moved this from Validate Peach to Done in Best Kanban May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

Enable razor UTs in-memory compilation
3 participants