Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable razor UTs in-memory compilation #9010

Closed
3 tasks
cristian-ambrosini-sonarsource opened this issue Apr 2, 2024 · 0 comments · Fixed by #9190, #9226 or #9214
Closed
3 tasks

Enable razor UTs in-memory compilation #9010

cristian-ambrosini-sonarsource opened this issue Apr 2, 2024 · 0 comments · Fixed by #9190, #9226 or #9214
Assignees
@Tim-Pohlmann
Labels
Sprint: Razor UTs Type: Tooling Tools make us productive.
Projects
Best Kanban

Comments

@cristian-ambrosini-sonarsource
Copy link
Contributor

cristian-ambrosini-sonarsource commented Apr 2, 2024 •
edited by CristianAmbrosini

  • Link all the steps to allow razor UTs to run with in-memory compilation.
  • Fix razor symbol reference issue
  • Final cleanup:
    • There's probably a build locator (or other) dependency that will go away
    • Verifier IsRazor property and CompileRazor, LangVersion, PrepareRazorProject, PrepareRazorFiles and RestorePackages methods will go away
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource changed the title Cleanup and remove old implementation Cleanup and removal of the old implementation Apr 2, 2024
@github-actions github-actions bot added this to To do in Best Kanban Apr 2, 2024
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from To do to In progress in Best Kanban Apr 4, 2024
@CristianAmbrosini CristianAmbrosini mentioned this issue Apr 23, 2024
Merged
@CristianAmbrosini CristianAmbrosini changed the title Cleanup and removal of the old implementation Enable razor UT in-memory compilation Apr 23, 2024
@CristianAmbrosini CristianAmbrosini changed the title Enable razor UT in-memory compilation Enable razor UTs in-memory compilation Apr 23, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Apr 24, 2024
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Apr 25, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Apr 26, 2024
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Apr 26, 2024
Best Kanban automation moved this from Review approved to Validate Peach Apr 26, 2024
@Tim-Pohlmann Tim-Pohlmann mentioned this issue Apr 30, 2024
Merged
@Tim-Pohlmann Tim-Pohlmann moved this from Validate Peach to In progress in Best Kanban Apr 30, 2024
@Tim-Pohlmann Tim-Pohlmann reopened this Apr 30, 2024
@Tim-Pohlmann Tim-Pohlmann linked a pull request Apr 30, 2024 that will close this issue
Revert "Enable razor UTs in-memory compilation (#9190)" #9214
Merged
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Apr 30, 2024
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban May 2, 2024
@github-actions github-actions bot assigned Tim-Pohlmann and unassigned Tim-Pohlmann May 2, 2024
@github-actions github-actions bot moved this from In progress to Review approved in Best Kanban May 2, 2024
Best Kanban automation moved this from Review approved to Validate Peach May 2, 2024
@Tim-Pohlmann Tim-Pohlmann moved this from Validate Peach to Done in Best Kanban May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tim-Pohlmann Tim-Pohlmann

Labels
Sprint: Razor UTs Type: Tooling Tools make us productive.
Projects
Best Kanban
  
Done
Milestone
No milestone
3 participants
@Tim-Pohlmann @CristianAmbrosini @cristian-ambrosini-sonarsource