Use SonarAnalyzer.CSharp.Styling #9207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/Styling
branch
from
451d4c9
to
e252cf1
Compare
|
|
sebastien-marichal
approved these changes
Apr 29, 2024
| @@ -1,6 +1,10 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project> | |||
| <ItemGroup> | |||
| <PackageReference Include="SonarAnalyzer.CSharp.Styling" Version="9.24.0.89429"> | |||
There was a problem hiding this comment.
Same question as for sonar-scanner-msbuild.
Could this be updated when running the set-version.ps1 script?
There was a problem hiding this comment.
No, because set-version is setting the value of the next release, while this one is the latest finished release.
And I don't expect the need to update this every time, as we won't update the rules with every single release.
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.