Use SonarAnalyzer.CSharp.Styling #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/Styling
branch
from
448d733
to
943de99
Compare
pavel-mikula-sonarsource
requested review from
sebastien-marichal
and removed request for
sebastien-marichal
pavel-mikula-sonarsource
assigned sebastien-marichal and unassigned pavel-mikula-sonarsource
pavel-mikula-sonarsource
moved this from In progress
to Review in progress
in S4NET Kanban
|
sebastien-marichal
approved these changes
Apr 29, 2024
| @@ -1,6 +1,10 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project> | |||
| <ItemGroup> | |||
| <PackageReference Include="SonarAnalyzer.CSharp.Styling" Version="9.24.0.89429"> | |||
There was a problem hiding this comment.
Do we want to let dependatbot/renovate do the update?
Not sure how hard it could be, but our set-script.ps1 could set the version as well to use the latest. To make things easier, we could set the version like so:
Suggested change
| <PackageReference Include="SonarAnalyzer.CSharp.Styling" Version="9.24.0.89429"> | |
| <PackageReference Include="SonarAnalyzer.CSharp.Styling" Version="9.24.0.*"> |
There was a problem hiding this comment.
We cannot use "*" due to json lock files. Each release of sonar-dotnet would break build of all other projects.
We will let update it manually, or let renovate do the job for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as SonarSource/sonar-dotnet#9207