Refactor: Extract common method to check if any ancestor belongs to SyntaxKind #9202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
added
the
Type: Improvement
github-actions
bot
assigned gregory-paidis-sonarsource and unassigned mary-georgiou-sonarsource
|
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned gregory-paidis-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
github-actions
bot
moved this from Review approved
to Review in progress
in Best Kanban
mary-georgiou-sonarsource
force-pushed
the
mary/extract-ancenstors-methdo
branch
from
9600f69
to
5ffc777
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/extract-ancenstors-methdo
branch
from
5ffc777
to
67f9cda
Compare
pavel-mikula-sonarsource
requested changes
May 1, 2024
analyzers/src/SonarAnalyzer.CSharp/Helpers/CSharpSyntaxHelper.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Helpers/CSharpSyntaxHelper.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
analyzers/src/SonarAnalyzer.VisualBasic/Helpers/VisualBasicSyntaxHelper.cs
Show resolved
Hide resolved
|
@pavel-mikula-sonarsource there are two more codesmells regarding the |
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
mary-georgiou-sonarsource
force-pushed
the
mary/extract-ancenstors-methdo
branch
from
2dcb177
to
0a31d21
Compare
|
|
pavel-mikula-sonarsource
approved these changes
May 2, 2024
| @@ -85,7 +85,7 @@ public override void Visit(SyntaxNode node) | |||
| public override void VisitIdentifierName(IdentifierNameSyntax node) => | |||
| DereferencesMethodArguments |= | |||
| argumentNames.Contains(node.GetName()) | |||
| && node.HasAncestorOfKind(AwaitExpression, | |||
| && node.HasAncestor(AwaitExpression, | |||
There was a problem hiding this comment.
Suggested change
| && node.HasAncestor(AwaitExpression, | |
| && node.HasAncestor( | |
| AwaitExpression, |
There was a problem hiding this comment.
You can fix this in your next PR, I'll merge this one now as I need to nuke the whole helper file
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.