fix codesmells

SonarSource · May 2, 2024 · 2dcb177 · 2dcb177
1 parent d92884e
commit 2dcb177
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/analyzers/src/SonarAnalyzer.CSharp/Helpers/CSharpSyntaxHelper.cs b/analyzers/src/SonarAnalyzer.CSharp/Helpers/CSharpSyntaxHelper.cs
@@ -218,11 +218,11 @@ public static bool IsLeftSideOfAssignment(this ExpressionSyntax expression)
     }
 
     public static bool IsComment(this SyntaxTrivia trivia) =>
-        trivia.Kind() switch
-        {
-            SyntaxKind.SingleLineCommentTrivia or SyntaxKind.MultiLineCommentTrivia or SyntaxKind.SingleLineDocumentationCommentTrivia or SyntaxKind.MultiLineDocumentationCommentTrivia => true,
-            _ => false,
-        };
+        trivia.IsAnyKind(
+            SyntaxKind.SingleLineCommentTrivia,
+            SyntaxKind.MultiLineCommentTrivia,
+            SyntaxKind.SingleLineDocumentationCommentTrivia,
+            SyntaxKind.MultiLineDocumentationCommentTrivia);
 
     // creates a QualifiedNameSyntax "a.b"
     public static QualifiedNameSyntax BuildQualifiedNameSyntax(string a, string b) =>

diff --git a/analyzers/src/SonarAnalyzer.VisualBasic/Helpers/VisualBasicSyntaxHelper.cs b/analyzers/src/SonarAnalyzer.VisualBasic/Helpers/VisualBasicSyntaxHelper.cs
@@ -121,7 +121,8 @@ expression switch
             InvocationExpressionSyntax invocation => IsOn(invocation.Expression, onKind),
             // This is a simplification as we don't check where the method is defined (so this could be this or base)
             GlobalNameSyntax or GenericNameSyntax or IdentifierNameSyntax or QualifiedNameSyntax => true,
-            MemberAccessExpressionSyntax memberAccessExpression when memberAccessExpression.IsKind(SyntaxKind.SimpleMemberAccessExpression) => memberAccessExpression.Expression.RemoveParentheses().IsKind(onKind),
+            MemberAccessExpressionSyntax memberAccessExpression when memberAccessExpression.IsKind(SyntaxKind.SimpleMemberAccessExpression) =>
+                memberAccessExpression.Expression.RemoveParentheses().IsKind(onKind),
             ConditionalAccessExpressionSyntax conditionalAccess => conditionalAccess.Expression.RemoveParentheses().IsKind(onKind),
             _ => false,
         };
@@ -152,11 +153,10 @@ public static bool IsLeftSideOfAssignment(this ExpressionSyntax expression)
     }
 
     public static bool IsComment(this SyntaxTrivia trivia) =>
-    trivia.Kind() switch
-    {
-        SyntaxKind.CommentTrivia or SyntaxKind.DocumentationCommentExteriorTrivia or SyntaxKind.DocumentationCommentTrivia => true,
-        _ => false,
-    };
+        trivia.IsAnyKind(
+            SyntaxKind.CommentTrivia,
+            SyntaxKind.DocumentationCommentExteriorTrivia,
+            SyntaxKind.DocumentationCommentTrivia);
 
     public static Location FindIdentifierLocation(this MethodBlockBaseSyntax methodBlockBase) =>
         GetIdentifierOrDefault(methodBlockBase)?.GetLocation();