New Rule S6494: The value type properties of a model class should be nullable or marked as "Required" to avoid under-posting. #9099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analyzers/tests/SonarAnalyzer.Test/TestCases/AvoidUnderPosting.CSharp12.cs
Outdated
Show resolved
Hide resolved
martin-strecker-sonarsource
requested changes
Apr 17, 2024
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/new-rule-S6964
branch
from
f010cbb
to
9346ffd
Compare
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/new-rule-S6964
branch
3 times, most recently
from
b31361d
to
3d67e2d
Compare
martin-strecker-sonarsource
requested changes
Apr 23, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/new-rule-S6964
branch
from
3d67e2d
to
4011555
Compare
|
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/new-rule-S6964
branch
from
4011555
to
095d670
Compare
martin-strecker-sonarsource
requested changes
Apr 29, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp9.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/new-rule-S6964
branch
from
46f7a00
to
a87ea03
Compare
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/new-rule-S6964
branch
from
a87ea03
to
d3b818f
Compare
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/new-rule-S6964
branch
from
d3b818f
to
4bf891e
Compare
| || (!namedType.IsRecord() | ||
| && !namedType.IsValueType | ||
| && !namedType.IsInterface() | ||
| && !namedType.Is(KnownType.System_String) |
There was a problem hiding this comment.
System.String doesn't have a default constructor, but it has a customer binder.
martin-strecker-sonarsource
requested changes
Apr 30, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp12.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.cs
Show resolved
Hide resolved
martin-strecker-sonarsource
approved these changes
Apr 30, 2024
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/new-rule-S6964
branch
from
7416788
to
566d219
Compare
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/new-rule-S6964
branch
from
566d219
to
52bf94d
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9094
RSPEC needs update (message and location was changed).