Post-rebase cleanup

SonarSource · Apr 30, 2024 · 4bf891e · 4bf891e
1 parent 8d6af9f
commit 4bf891e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/...ers/its/expected/ManuallyAddedNoncompliantIssues.CS/S6967-IntentionalFindings-net8.0.json b/...ers/its/expected/ManuallyAddedNoncompliantIssues.CS/S6967-IntentionalFindings-net8.0.json
@@ -1,5 +1,11 @@
 {
   "Issues": [
+    {
+      "Id": "S6967",
+      "Message": "ModelState.IsValid should be checked in controller actions.",
+      "Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/ManuallyAddedNoncompliantIssues.CS/IntentionalFindings/S6964.cs#L15",
+      "Location": "Line 15 Position 41-47"
+    },
     {
       "Id": "S6967",
       "Message": "ModelState.IsValid should be checked in controller actions.",

diff --git a/analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs b/analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
@@ -58,7 +58,7 @@ public sealed class AvoidUnderPosting : SonarDiagnosticAnalyzer
     private static void ProcessControllerMethods(SonarSyntaxNodeReportingContext context, ConcurrentDictionary<ITypeSymbol, bool> examinedTypes)
     {
         if (context.SemanticModel.GetDeclaredSymbol(context.Node) is IMethodSymbol method
-            && method.IsControllerMethod())
+            && method.IsControllerActionMethod())
         {
             var modelParameterTypes = method.Parameters
                 .Where(x => !HasValidateNeverAttribute(x))

diff --git a/analyzers/src/SonarAnalyzer.Common/Helpers/KnownType.cs b/analyzers/src/SonarAnalyzer.Common/Helpers/KnownType.cs
@@ -302,7 +302,7 @@ public sealed partial class KnownType
         public static readonly KnownType System_ComponentModel_DataAnnotations_RegularExpressionAttribute = new("System.ComponentModel.DataAnnotations.RegularExpressionAttribute");
         public static readonly KnownType System_ComponentModel_DataAnnotations_IValidatableObject = new("System.ComponentModel.DataAnnotations.IValidatableObject");
         public static readonly KnownType System_ComponentModel_DataAnnotations_RequiredAttribute = new("System.ComponentModel.DataAnnotations.RequiredAttribute");
-        public static readonly KnownType System_ComponentModel_DataAnnotations_ValidationAttribute = new("System.ComponentModel.DataAnnotations.ValidationAttribute");                
+        public static readonly KnownType System_ComponentModel_DataAnnotations_ValidationAttribute = new("System.ComponentModel.DataAnnotations.ValidationAttribute");
         public static readonly KnownType System_ComponentModel_DefaultValueAttribute = new("System.ComponentModel.DefaultValueAttribute");
         public static readonly KnownType System_ComponentModel_EditorBrowsableAttribute = new("System.ComponentModel.EditorBrowsableAttribute");
         public static readonly KnownType System_ComponentModel_LocalizableAttribute = new("System.ComponentModel.LocalizableAttribute");