New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Rule S2223: cleanup and performance #6761
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
874001a
Add more UTs to be more explicit about access modifiers
mary-georgiou-sonarsource 438e2dc
replace semantic model operations with AST ones
mary-georgiou-sonarsource eed9667
Add test with multiple filed declarations in one line
mary-georgiou-sonarsource 73f5639
more UTS
mary-georgiou-sonarsource 016aebf
update ITs
mary-georgiou-sonarsource 9537be3
delete not useful condition and update UTs
mary-georgiou-sonarsource c906d02
remove check for const as if there is static keyword then const will …
mary-georgiou-sonarsource 47f6635
if no access modifier exist the field is private
mary-georgiou-sonarsource f6cf3ad
Revert "update ITs"
mary-georgiou-sonarsource 1f6a2c1
cover also case of private protected modifier
mary-georgiou-sonarsource 0b61972
add more UTs
mary-georgiou-sonarsource 1ad2631
exclude volatile fields from the raising issues
mary-georgiou-sonarsource 53bab05
update rsepc for rule S2223
mary-georgiou-sonarsource 1947aba
apply comments
mary-georgiou-sonarsource File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
volatile
field should also be irrelevant asvolatile
indicates some advanced multi-threading voodoo is going on here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe good to exclude - per MSDN docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, while I see a
public static
volatile non-readonly field as dangerous as apublic static
non-volatile non-readonly one, and it seems that there are almost always ways to have the fieldprivate
(at least for the typical scenarios of sentinel loopers or counters), let's assume that the person using it has a sound multi-threading model and a solid understanding of it.So I am OK with disabling the check when
volatile
is encountered.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martin-strecker-sonarsource to resolve this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martin-strecker-sonarsource and I had an offiline convertation on the matter and agreed to the current solution regarding
volatile
modifier.