Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Rule S2223: cleanup and performance #6761

Merged
merged 14 commits into from Feb 22, 2023
Merged

Improve Rule S2223: cleanup and performance #6761

merged 14 commits into from Feb 22, 2023

Commits on Feb 16, 2023

  1. Add more UTs to be more explicit about access modifiers

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 16, 2023
    Copy the full SHA
    874001a View commit details
    Browse the repository at this point in the history

  2. replace semantic model operations with AST ones

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 16, 2023
    Copy the full SHA
    438e2dc View commit details
    Browse the repository at this point in the history

  3. Add test with multiple filed declarations in one line

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 16, 2023
    Copy the full SHA
    eed9667 View commit details
    Browse the repository at this point in the history

  4. more UTS

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 16, 2023
    Copy the full SHA
    73f5639 View commit details
    Browse the repository at this point in the history

  5. update ITs

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 16, 2023
    Copy the full SHA
    016aebf View commit details
    Browse the repository at this point in the history

  6. delete not useful condition and update UTs

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 16, 2023
    Copy the full SHA
    9537be3 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. remove check for const as if there is static keyword then const will … 

    …never be there
    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 17, 2023
    Copy the full SHA
    c906d02 View commit details
    Browse the repository at this point in the history

  2. if no access modifier exist the field is private

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 17, 2023
    Copy the full SHA
    47f6635 View commit details
    Browse the repository at this point in the history

  3. Revert "update ITs" 

    This reverts commit 016aebf.
    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 17, 2023
    Copy the full SHA
    f6cf3ad View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. cover also case of private protected modifier

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 21, 2023
    Copy the full SHA
    1f6a2c1 View commit details
    Browse the repository at this point in the history

  2. add more UTs

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 21, 2023
    Copy the full SHA
    0b61972 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. exclude volatile fields from the raising issues

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 22, 2023
    Copy the full SHA
    1ad2631 View commit details
    Browse the repository at this point in the history

  2. update rsepc for rule S2223

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 22, 2023
    Copy the full SHA
    53bab05 View commit details
    Browse the repository at this point in the history

  3. apply comments

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Feb 22, 2023
    Copy the full SHA
    1947aba View commit details
    Browse the repository at this point in the history